Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

conn: add timeout for ping #1477

Merged
merged 1 commit into from
Mar 5, 2021
Merged

conn: add timeout for ping #1477

merged 1 commit into from
Mar 5, 2021

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

as described in title

What is changed and how it works?

add timeout of 30s for ping

Check List

Tests

  • pass original test, hard to test I think

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716 lance6716 added this to the v2.0.2 milestone Mar 3, 2021
@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Mar 3, 2021
3pointer
3pointer approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lance6716 lance6716 merged commit cd9e901 into pingcap:master Mar 5, 2021
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Mar 5, 2021
@lance6716 @ti-srebot
cherry pick pingcap#1477 to release-2.0
d7f5948 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 5, 2021
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1481

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Mar 5, 2021
lance6716 added a commit that referenced this pull request Mar 5, 2021
@ti-srebot @lance6716
cherry pick #1477 to release-2.0 (#1481)
b4f1aec 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lance6716 <lance6716@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @ti-srebot @3pointer