Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

conn: add timeout for ping (#1477) #1481

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Mar 5, 2021

cherry-pick #1477 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1481

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/dm.git pr/1481:release-2.0-cd9e90106c58

What problem does this PR solve?

as described in title

What is changed and how it works?

add timeout of 30s for ping

Check List

Tests

  • pass original test, hard to test I think

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/cherry-pick This PR is just a cherry-pick (backport) labels Mar 5, 2021
@ti-srebot ti-srebot requested a review from 3pointer March 5, 2021 04:25
@lance6716 lance6716 merged commit b4f1aec into pingcap:release-2.0 Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants