Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: load table structure from dump files #1699

Merged
merged 35 commits into from
Jun 7, 2021
Merged

syncer: load table structure from dump files #1699

merged 35 commits into from
Jun 7, 2021

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented May 17, 2021 •
edited
Loading

What problem does this PR solve?

close #1697

What is changed and how it works?

  • as title
  • originally we use MySQL 5.7 & 8.0 as upstreams, they has different default CHARSET. Because DM ignores "table already exists" error and fetches table from downstream, only one table with one CHARSET will be created at downstream and DM loads it for two sharding tables. Now, DM will see table strcuture of diferent CHARSET, so set default in advance.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Breaking backward compatibility (but fix a bug)

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated and removed size/M labels May 17, 2021
@lance6716 lance6716 added this to the v2.0.4 milestone May 17, 2021
lichunzhu
lichunzhu reviewed May 18, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 18, 2021
@lance6716
Copy link
Collaborator Author

/hold

@lance6716
Copy link
Collaborator Author

/unhold

@lance6716
Copy link
Collaborator Author

/hold

@lance6716
Copy link
Collaborator Author

/unhold

@Ehco1996
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@Ehco1996: Thanks for your review. The bot only counts /lgtm from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Collaborator Author

/run-all-tests

2 similar comments
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 90638a6

@ti-chi-bot ti-chi-bot merged commit e120956 into pingcap:master Jun 7, 2021
ti-chi-bot pushed a commit to ti-chi-bot/dm that referenced this pull request Jun 7, 2021
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#1699
914baa4 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 7, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1754.

@lance6716
Copy link
Collaborator Author

/cherry-pick release-2.0

@ti-chi-bot
Copy link
Member

@lance6716: new pull request created: #1758.

In response to this:

/cherry-pick release-2.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/dm that referenced this pull request Jun 9, 2021
@lance6716 @ti-chi-bot
syncer: load table structure from dump files (pingcap#1699)
ce43e28
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 9, 2021
Merged
ti-chi-bot added a commit that referenced this pull request Jun 15, 2021
@ti-chi-bot
syncer: load table structure from dump files (#1699) (#1758)
b9f6fbf
@GMHDBJD GMHDBJD mentioned this pull request Jun 22, 2021
Merged
@lance6716 lance6716 mentioned this pull request Jul 26, 2021
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 26, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/XL status/can-merge status/LGT1 One reviewer already commented LGTM
Projects
None yet
Milestone
v2.0.4
5 participants
@lance6716 @Ehco1996 @ti-chi-bot @GMHDBJD @lichunzhu