Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

syncer: load table structure from dump files (#1699) #1758

Merged
merged 4 commits into from
Jun 15, 2021
Merged

syncer: load table structure from dump files (#1699) #1758

merged 4 commits into from
Jun 15, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1699

What problem does this PR solve?

close #1697

What is changed and how it works?

  • as title
  • originally we use MySQL 5.7 & 8.0 as upstreams, they has different default CHARSET. Because DM ignores "table already exists" error and fetches table from downstream, only one table with one CHARSET will be created at downstream and DM loads it for two sharding tables. Now, DM will see table strcuture of diferent CHARSET, so set default in advance.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Breaking backward compatibility (but fix a bug)

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-1699-to-release-2.0 branch from 89d36ea to ce43e28 Compare June 9, 2021 11:47
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 9, 2021
Merged
@ti-chi-bot ti-chi-bot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/XL type/cherry-pick-for-release-2.0 labels Jun 9, 2021
@ti-chi-bot ti-chi-bot requested review from lance6716 and lichunzhu June 9, 2021 11:47
@lance6716
Copy link
Collaborator

/lgtm

@ti-chi-bot
Copy link
Member Author

@lance6716: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jun 9, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 4800cba

@ti-chi-bot ti-chi-bot merged commit b9f6fbf into pingcap:release-2.0 Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees

@lance6716 lance6716

Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/XL status/can-merge status/LGT1 One reviewer already commented LGTM type/cherry-pick-for-release-2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @lance6716 @Ehco1996