Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

scheduler: check invalid source before apply last bound (#1683) #1713

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1683

What problem does this PR solve?

When dm-master degrade from higher versions and then upgrade to higher versions, there might be some bounds without source configs.

What is changed and how it works?

Check source configs before we apply last bounds.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@ti-chi-bot ti-chi-bot added size/L status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0 labels May 21, 2021
@lance6716
Copy link
Collaborator

waiting #1714

@lance6716
Copy link
Collaborator

/lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 21, 2021
@lance6716 lance6716 added the require-LGT1 for small PR, LGT1 is enough label May 21, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: e0b955c

@ti-chi-bot ti-chi-bot merged commit 012e3d6 into pingcap:release-2.0 May 21, 2021
@GMHDBJD GMHDBJD modified the milestone: v2.0.4 Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
require-LGT1 for small PR, LGT1 is enough size/L status/can-merge status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants