Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dep: update tidb-tools to support AWS privileges #947

Merged
merged 3 commits into from
Aug 28, 2020
Merged

dep: update tidb-tools to support AWS privileges #947

merged 3 commits into from
Aug 28, 2020

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

update tidb-tools to support AWS privileges

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added dependencies Pull requests that update a dependency file needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 priority/unimportant Really minor change, requires approval from secondary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 28, 2020
GMHDBJD
GMHDBJD reviewed Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

csuzhangxc
csuzhangxc approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 28, 2020
@GMHDBJD GMHDBJD added the status/LGT1 One reviewer already commented LGTM label Aug 28, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.2 milestone Aug 28, 2020
@csuzhangxc csuzhangxc removed the status/LGT1 One reviewer already commented LGTM label Aug 28, 2020
@lance6716 lance6716 added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT1 One reviewer already commented LGTM labels Aug 28, 2020
@csuzhangxc csuzhangxc removed the status/LGT1 One reviewer already commented LGTM label Aug 28, 2020
@csuzhangxc csuzhangxc merged commit 172359c into pingcap:master Aug 28, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 28, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #950

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Aug 28, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Aug 31, 2020
@lance6716 lance6716 deleted the update-tools branch July 6, 2021 02:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked already-update-release-note The release note is updated. Add this label once the release note is updated dependencies Pull requests that update a dependency file priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
v2.0.0 RC.2
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-srebot @csuzhangxc @GMHDBJD