Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dep: update tidb-tools to support AWS privileges (#947) #950

Merged
merged 2 commits into from
Aug 28, 2020
Merged

dep: update tidb-tools to support AWS privileges (#947) #950

merged 2 commits into from
Aug 28, 2020

Conversation

ti-srebot
Copy link

cherry-pick #947 to release-2.0

What problem does this PR solve?

update tidb-tools to support AWS privileges

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@ti-srebot ti-srebot mentioned this pull request Aug 28, 2020
Merged
@ti-srebot ti-srebot added dependencies Pull requests that update a dependency file needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/unimportant Really minor change, requires approval from secondary reviewers type/cherry-pick This PR is just a cherry-pick (backport) labels Aug 28, 2020
csuzhangxc
csuzhangxc reviewed Aug 28, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added this to the v2.0.0 RC.2 milestone Aug 28, 2020
@lance6716
Copy link
Collaborator

/run-all-tests

GMHDBJD
GMHDBJD approved these changes Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added the status/LGT1 One reviewer already commented LGTM label Aug 28, 2020
@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 28, 2020
@lance6716 lance6716 merged commit 055c6dd into pingcap:release-2.0 Aug 28, 2020
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated dependencies Pull requests that update a dependency file priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0 RC.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @lance6716 @csuzhangxc @GMHDBJD