This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
task_checker: don't auto-resume for wrong datetime value #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
priority/unimportant
csuzhangxc
reviewed
Sep 2, 2020
pkg/retry/errors.go
Outdated
| @@ -37,6 +37,7 @@ var ( | |||
| UnsupportedDMLMsgs = []string{ | |||
| "Error 1062: Duplicate entry", | |||
| "Error 1406: Data too long for column", | |||
| "Error 1366: Incorrect datetime value", | |||
There was a problem hiding this comment.
How about handing other Error 1366 too? maybe you can search TiDB repo (tidb/errno/errcode.go) to got the meaning of this code.
There was a problem hiding this comment.
I guess it's no help keep retrying
seems in fact most errors could not resolved by retry 🤔
There was a problem hiding this comment.
seems in fact most errors could not resolved by retry
YES, but we don't know which errors could be resolved by retry, 😢
csuzhangxc
added
status/LGT1
GMHDBJD
added
the
needs-cherry-pick-release-2.0
lance6716
added
status/LGT2
|
cherry pick to release-2.0 in PR #979 |
ti-srebot
added
already-cherry-pick-2.0
GMHDBJD
pushed a commit
that referenced
this pull request
Sep 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #921
What is changed and how it works?
add this type of error to
UnsupportedDMLMsgs(can't verify this is the right place)Check List
Tests
Code changes
Side effects
Related changes