Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

task_checker: don't auto-resume for wrong datetime value (#977) #979

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

ti-srebot
Copy link

cherry-pick #977 to release-2.0


What problem does this PR solve?

fix #921

What is changed and how it works?

add this type of error to UnsupportedDMLMsgs (can't verify this is the right place)

Check List

Tests

  • hard to find a MariaDB 10.0, can't imitate using newer MariaDB and mysql56_temporal_format = OFF

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@ti-srebot ti-srebot added priority/unimportant Really minor change, requires approval from secondary reviewers type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 3, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Sep 3, 2020
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD merged commit a5574b6 into pingcap:release-2.0 Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants