Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: update scale out config #13578

Merged
merged 7 commits into from
May 17, 2023
Merged

ticdc: update scale out config #13578

merged 7 commits into from
May 17, 2023

Conversation

overvenus
Copy link
Member

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update TiCDC scale out config.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@overvenus
ticdc: update scale out config
867053c 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 3, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90
  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2023
@overvenus
update description
bbe162b 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2023
@overvenus overvenus mentioned this pull request Apr 3, 2023
Closed
22 tasks
@overvenus overvenus requested a review from 3AceShowHand April 3, 2023 06:46
nongfushanquan
nongfushanquan reviewed Apr 3, 2023
View reviewed changes
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Show resolved Hide resolved
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label May 9, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 9, 2023
@qiancai qiancai added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-7.0 area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. and removed missing-translation-status This PR does not have translation status info. labels May 9, 2023
@qiancai qiancai self-assigned this May 9, 2023
qiancai
qiancai reviewed May 9, 2023
View reviewed changes
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
@overvenus @qiancai
Apply suggestions from code review
05c46f4 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 9, 2023
@qiancai qiancai added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed translation/doing This PR’s assignee is translating this PR. labels May 10, 2023
@qiancai qiancai added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label May 10, 2023
@qiancai qiancai mentioned this pull request May 11, 2023
Merged
17 tasks
lilin90
lilin90 reviewed May 15, 2023
View reviewed changes
ticdc/ticdc-sink-to-kafka.md
# * 当 `region-threshold` 和 `write-key-threshold` 同时配置时，
# TiCDC 将优先检查修改行数是否大于 `write-key-threshold`，
# 如果不超过，则再检查 Region 个数是否大于 `region-threshold`。
write-key-threshold = 30000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是特意写的 30000 吗？是否需要跟 ticdc/ticdc-changefeed-config.md 文档里的 0 保持一致？

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overvenus PTAL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

特意写的，这个是推荐配置，0 是默认配置

lilin90
lilin90 approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2023
@qiancai
Copy link
Collaborator

qiancai commented May 17, 2023

/verify

@ti-chi-bot ti-chi-bot mentioned this pull request May 17, 2023
Merged
17 tasks
@qiancai
Copy link
Collaborator

qiancai commented May 17, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 4abe768

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0366555 into pingcap:master May 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 17, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13992.

ti-chi-bot bot pushed a commit that referenced this pull request May 17, 2023
@ti-chi-bot
ticdc: update scale out config (#13578) (#13992)
cd85805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@lilin90 lilin90 lilin90 approved these changes

@3AceShowHand 3AceShowHand Awaiting requested review from 3AceShowHand

Assignees

@qiancai qiancai

Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@overvenus @ti-chi-bot @qiancai @lilin90 @nongfushanquan