Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: update scale out config #13532

Merged
merged 5 commits into from
May 17, 2023
Merged

ticdc: update scale out config #13532

merged 5 commits into from
May 17, 2023

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented May 10, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-7.0 labels May 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 10, 2023
@qiancai qiancai marked this pull request as draft May 10, 2023 11:27
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2023
@qiancai qiancai changed the title ticdc: update scale out config [WIP] ticdc: update scale out config May 10, 2023
qiancai
qiancai commented May 11, 2023
View reviewed changes
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
@qiancai qiancai changed the title [WIP] ticdc: update scale out config ticdc: update scale out config May 11, 2023
@qiancai qiancai marked this pull request as ready for review May 11, 2023 05:40
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2023
@qiancai qiancai requested a review from overvenus May 11, 2023 05:41
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2023
@qiancai qiancai mentioned this pull request May 12, 2023
Merged
16 tasks
lilin90
lilin90 reviewed May 15, 2023
View reviewed changes
ticdc/ticdc-changefeed-config.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
ticdc/ticdc-sink-to-kafka.md Outdated
# * When `region-threshold` and `write-key-threshold` are configured at the same time:
# TiCDC will check if the number of modified rows is greater than `write-key-threshold` first.
# If not, next check if the number of Regions is greater than `region-threshold`.
write-key-threshold = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Chinese version, it is 30000. See pingcap/docs-cn#13578 (comment). Please help check and keep them consistent.

@qiancai @lilin90
Apply suggestions from code review
4263d67 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
qiancai
qiancai commented May 17, 2023
View reviewed changes
ticdc/ticdc-sink-to-kafka.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2023
@qiancai
Copy link
Collaborator Author

qiancai commented May 17, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 3e68b9f

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2023
@ti-chi-bot ti-chi-bot bot merged commit 05f828c into pingcap:master May 17, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 17, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13588.

ti-chi-bot bot pushed a commit that referenced this pull request May 17, 2023
@ti-chi-bot
ticdc: update scale out config (#13532) (#13588)
b759277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees
No one assigned
Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qiancai @ti-chi-bot @overvenus @lilin90