Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add smooth upgrade TiDB introduction doc #14013

Merged
merged 19 commits into from
May 25, 2023

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented May 17, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

This PR is used to add introduction doc for smooth upgrade.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@zimulala zimulala added the v7.1 This PR/issue applies to TiDB v7.1. label May 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2023
@Oreoxmt Oreoxmt requested a review from ran-huang May 18, 2023 01:38
@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels May 18, 2023
@Oreoxmt Oreoxmt requested a review from benmaoer May 18, 2023 01:38
faq/upgrade-faq.md Outdated Show resolved Hide resolved
upgrade-tidb.md Outdated Show resolved Hide resolved
upgrade-tidb.md Outdated Show resolved Hide resolved
upgrade-tidb.md Outdated Show resolved Hide resolved
upgrade-tidb.md Outdated Show resolved Hide resolved
upgrade-tidb.md Outdated Show resolved Hide resolved
upgrade-tidb.md Outdated Show resolved Hide resolved
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
upgrade-tidb.md Outdated Show resolved Hide resolved
smooth-upgrade-tidb.md Outdated Show resolved Hide resolved

* BR,Lightning (Physical Import Mode) 和通过 ingest 方式导入数据等组件:升级过程中不能处理这类组件的操作,是因为这些操作中可能将 paused 状态的 DDL 拷贝到 TiDB。但是此状态的 DDL 不能自动 resume,可能导致后续 DDL 卡住的情况。

* DM,Lightning (Logical Import Mode) 和 TiCDC 等组件。即在升级过程中,通过此类组件导入 SQL 到 TiDB,且其中有 DDL 操作,那么会导致此导入操作阻塞,此外可能存在未定义错误。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* DM,Lightning (Logical Import Mode) 和 TiCDC 等组件。即在升级过程中,通过此类组件导入 SQL 到 TiDB,且其中有 DDL 操作,那么会导致此导入操作阻塞,此外可能存在未定义错误。
* DM 和 TiCDC 等组件。即在升级过程中,通过此类组件导入 SQL 到 TiDB,且其中有 DDL 操作,那么会导致此导入操作阻塞,此外可能存在未定义错误。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尽量不要出现 lightning 的字样,另外这种导入后续不是 logical 导入。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

什么原因?“Lightning (Physical Import Mode)” 要改吗?

@zimulala
Copy link
Contributor Author

PTAL @Benjamin2037

Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smooth-upgrade-tidb.md Outdated Show resolved Hide resolved
smooth-upgrade-tidb.md Outdated Show resolved Hide resolved
smooth-upgrade-tidb.md Outdated Show resolved Hide resolved
smooth-upgrade-tidb.md Outdated Show resolved Hide resolved
smooth-upgrade-tidb.md Outdated Show resolved Hide resolved
@zimulala
Copy link
Contributor Author

PTAL @ran-huang

smooth-upgrade-tidb.md Outdated Show resolved Hide resolved
smooth-upgrade-tidb.md Outdated Show resolved Hide resolved
smooth-upgrade-tidb.md Outdated Show resolved Hide resolved
@zimulala
Copy link
Contributor Author

PTAL @qiancai @ran-huang

1 similar comment
@zimulala
Copy link
Contributor Author

PTAL @qiancai @ran-huang

faq/upgrade-faq.md Outdated Show resolved Hide resolved
faq/upgrade-faq.md Outdated Show resolved Hide resolved
smooth-upgrade-tidb.md Outdated Show resolved Hide resolved
smooth-upgrade-tidb.md Outdated Show resolved Hide resolved
faq/upgrade-faq.md Outdated Show resolved Hide resolved
zimulala and others added 6 commits May 25, 2023 10:30
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Ran <huangran.alex@gmail.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2023
@ran-huang
Copy link
Contributor

/verify

@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 50278eb

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2023
@ti-chi-bot ti-chi-bot bot merged commit 7027ca1 into pingcap:master May 25, 2023
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 30, 2023
@zimulala zimulala deleted the zimuxia/pause-user-ddls branch June 19, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants