Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TiDB without manually Canceling DDL #39751

Closed
17 tasks done
zimulala opened this issue Dec 8, 2022 · 0 comments
Closed
17 tasks done

Upgrade TiDB without manually Canceling DDL #39751

zimulala opened this issue Dec 8, 2022 · 0 comments
Labels
feature/accepted This feature request is accepted by product managers sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement. type/new-feature

Comments

@zimulala
Copy link
Contributor

zimulala commented Dec 8, 2022

Feature Request

In the documentation, we said do not use DDL statements when upgrading:

In addition, during the cluster upgrade, DO NOT execute any DDL statement. Otherwise, the issue of undefined behavior might occur

Details:
https://docs.pingcap.com/tidb/dev/upgrade-tidb-using-tiup#:~:text=DO%20NOT%20upgrade,behavior%20might%20occur.
We'd better add a feature to ensure this, not just documentation.

Development Plan

User Doc

TODO List

Feature-related Issues

Feature-unrelated Issues

Future Works

  1. Do not allow running DDL jobs to be processed on different versions of TiDB.
  2. Consider not letting the new version of DDL jobs be processed on the old version of TiDB, and not letting the old version of DDL jobs be processed on the new version of TiDB.
  3. Can not perform admin cancel DDL during the upgrade.
@zimulala zimulala added type/enhancement The issue or PR belongs to an enhancement. sig/sql-infra SIG: SQL Infra labels Dec 8, 2022
@zimulala zimulala changed the title When upgrading TiDB, cancel the previous DDL Pause User DDL when Upgrading TiDB Apr 13, 2023
@zimulala zimulala changed the title Pause User DDL when Upgrading TiDB Pause user DDL when upgrading TiDB Apr 13, 2023
@zimulala zimulala added type/new-feature feature/accepted This feature request is accepted by product managers labels Apr 13, 2023
@zimulala zimulala changed the title Pause user DDL when upgrading TiDB Upgrade TiDB without manually Canceling DDL Aug 8, 2023
@zimulala zimulala closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accepted This feature request is accepted by product managers sig/sql-infra SIG: SQL Infra type/enhancement The issue or PR belongs to an enhancement. type/new-feature
Projects
None yet
Development

No branches or pull requests

1 participant