-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl, executor: executor change for pause/resume on ddl jobs (#43171) #43658
ddl, executor: executor change for pause/resume on ddl jobs (#43171) #43658
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
1 similar comment
/retest |
/ok-to-test |
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Done it in #43674 |
This is an automated cherry-pick of #43171
Add Pause/Resume admin command in parser and planner
What problem does this PR solve?
Issue Number: close #18015 #40041
Related issue number: #39751 #43061
Related PR: #43081
Problem Summary: Add pause/resume on ddl jobs
What is changed and how it works?
Add admin pause ddl jobs 3,5
;a. the job should be in Running or Queueing state
b. change the state to be Pausing on command issued, in another PR
c. background work will pause the job once scheduled, in another PR
Add admin resume ddl jobs 3,5
;a. the job should be paused
b. change the state to be Queueing on command issued, in another PR
c. background worker will continue the job, no need to change
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.