Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause add an index(write reorganization) and set a time window to resume #18015

Closed
scsldb opened this issue Jun 15, 2020 · 0 comments · Fixed by #43081, #43171 or #43297
Closed

Pause add an index(write reorganization) and set a time window to resume #18015

scsldb opened this issue Jun 15, 2020 · 0 comments · Fixed by #43081, #43171 or #43297
Labels
feature/accepted This feature request is accepted by product managers priority/P2 The issue has P2 priority. type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@scsldb
Copy link

scsldb commented Jun 15, 2020

Description

In some scenarios, latencies of the SQL statements are very essential and should be stable all the time. However, the DDL CREATE TABLE ... ADD INDEX may affect the latencies of other statements: https://docs.pingcap.com/tidb/stable/online-workloads-and-add-index-operations.

For now, TiDB provided tidb_ddl_reorg_worker_cnt and tidb_ddl_reorg_batch_size system variables. By decreasing them, the resources occipued ADD INDEX operation can be lower, but they cannot be none.

It can be better if such features are provided:

  • The ability to pause a running DDL statement like ADD INDEX.
  • The ability to set a time-based trigger for customized SQL statements.

By the features above users are able to pause a running ADD INDEX manually, or schedule the ADD INDEX operations to make sure they will be ran at a suitable time.

Category

Feature, Stability

Value

Reduce latency jitter in peak periods of core application scenarios.

@scsldb scsldb added priority/P1 The issue has P1 priority. type/feature-request Categorizes issue or PR as related to a new feature. labels Jun 15, 2020
@scsldb scsldb added this to the v5.0-alpha.1 milestone Jun 15, 2020
@scsldb scsldb modified the milestones: v5.0.0-alpha.1, pools Jul 15, 2020
@scsldb scsldb added the feature/accepted This feature request is accepted by product managers label Jul 16, 2020
@zz-jason zz-jason removed their assignment Jul 16, 2020
@ilovesoup ilovesoup added priority/P2 The issue has P2 priority. and removed priority/P1 The issue has P1 priority. labels Sep 1, 2020
dhysum added a commit to dhysum/tidb that referenced this issue May 10, 2023
dhysum added a commit to dhysum/tidb that referenced this issue May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accepted This feature request is accepted by product managers priority/P2 The issue has P2 priority. type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
3 participants