Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl, parser, executor, ddl worker and reorganization worker: admin pause/resume ddl jobs #43672

Closed
wants to merge 41 commits into from

Conversation

dhysum
Copy link
Contributor

@dhysum dhysum commented May 10, 2023

What problem does this PR solve?
Issue Number: close #18015 #40041

Related issue number: #39751 #43061

Problem Summary:

  • admin pause ddl jobs 3,5;
  • admin resume ddl jobs 3,5;

pause an running DDL; and resume the paused DDL.

What is changed and how it works?

Once received the admin pause request, it will mark the Job as pausing, then the background worker will turn the DDL job to be paused and mark it as not processing. While, the admin resume is the contrary way.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

ti-chi-bot and others added 30 commits April 20, 2023 14:47
…ingcap#43329) (pingcap#43331)

* fixup

* fixup

* make linter happy

---------

Co-authored-by: qw4990 <zhangyuanjia@pingcap.com>
…ingcap#43293) (pingcap#43340)

* add retry error

* add log

* annotate info on write tikv error

* add comments

* fix comments

* bazel

* fix ut

---------

Co-authored-by: D3Hunter <jujj603@gmail.com>
@dhysum dhysum requested a review from a team as a code owner May 10, 2023 04:15
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. labels May 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023

Hi @dhysum. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhysum dhysum changed the title ddl pause and resume ddl, parser, executor, ddl worker and reorganization worker: admin pause/resume ddl jobs May 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@dhysum
Copy link
Contributor Author

dhysum commented May 10, 2023

Wrong taget branch

@dhysum dhysum closed this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/invalid-title needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pause add an index(write reorganization) and set a time window to resume
5 participants