Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0/reference, v2.1/reference, dev/reference: update stats related configuration #1526

Merged
merged 20 commits into from
Jul 23, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jun 27, 2019

What is changed, added or deleted?

Configuration of statistics is updated.

What is the related PR or file link(s)?

Which version does your change affect?

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

@yikeke yikeke self-requested a review July 10, 2019 05:23
@yikeke
Copy link
Contributor

yikeke commented Jul 10, 2019

Important Update: We have added a markdownlint static check in the CI check to improve the quality of our documentation, so your unclosed PR might fail the CI check now.

First, you should merge upstream master to your branch, so the upstream changes might resolve the issues found by the CI check. Then, click details beside the ci/circleci: lint — Your tests failed on CircleCI message, and you can check the details for the failure and fix all the issues in your PR. It is recommended to install "markdownlint" extension in your VS Code editor, so it will check all potential issues that fail the CI check.

@lamxTyler If you have any problem with troubleshooting, please consult @yikeke for help. Thanks for your cooperation~

Ref: #1494

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PTAL again. @zz-jason

@yikeke yikeke added the dev label Jul 12, 2019
@yikeke yikeke changed the title dev/reference: update stats related configuration v3.0/reference, v2.1/reference, dev/reference: update stats related configuration Jul 12, 2019
@alivxxx alivxxx requested a review from winoros July 23, 2019 04:54
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants