-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain: load stats when stats lease is 0 #10771
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10771 +/- ##
================================================
+ Coverage 80.2991% 80.3195% +0.0204%
================================================
Files 416 416
Lines 88265 88326 +61
================================================
+ Hits 70876 70943 +67
+ Misses 12198 12191 -7
- Partials 5191 5192 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
/run-all-tests |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Sometimes, we need to automatically load stats even if the stats lease is 0.
What is changed and how it works?
Load stats even when stats lease is 0, and use
3s
as the default interval.Check List
Tests
Change the stats lease to 0, and the log shows
["init stats info time"] ["take time"=2.187982ms]
Code changes
Side effects
Related changes