Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: load stats when stats lease is 0 #10771

Merged
merged 7 commits into from
Jun 13, 2019
Merged

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jun 11, 2019

What problem does this PR solve?

Sometimes, we need to automatically load stats even if the stats lease is 0.

What is changed and how it works?

Load stats even when stats lease is 0, and use 3s as the default interval.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Change the stats lease to 0, and the log shows ["init stats info time"] ["take time"=2.187982ms]

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@alivxxx alivxxx added type/enhancement The issue or PR belongs to an enhancement. component/statistics labels Jun 11, 2019
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #10771 into master will increase coverage by 0.0204%.
The diff coverage is 88.8888%.

@@               Coverage Diff                @@
##             master     #10771        +/-   ##
================================================
+ Coverage   80.2991%   80.3195%   +0.0204%     
================================================
  Files           416        416                
  Lines         88265      88326        +61     
================================================
+ Hits          70876      70943        +67     
+ Misses        12198      12191         -7     
- Partials       5191       5192         +1

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zz-jason
zz-jason previously approved these changes Jun 11, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 11, 2019
XuHuaiyu
XuHuaiyu previously approved these changes Jun 11, 2019
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member

coocood commented Jun 11, 2019

LGTM

@alivxxx
Copy link
Contributor Author

alivxxx commented Jun 11, 2019

/run-all-tests

@alivxxx alivxxx dismissed stale reviews from XuHuaiyu and zz-jason via 3d249c4 June 12, 2019 03:20
@alivxxx
Copy link
Contributor Author

alivxxx commented Jun 12, 2019

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 2b61127 into pingcap:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants