Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: add description about canal-json content-compatible. #15579

Merged
merged 5 commits into from
Dec 7, 2023
Merged

cdc: add description about canal-json content-compatible. #15579

merged 5 commits into from
Dec 7, 2023

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Nov 30, 2023 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

TiCDC introduces content-compatible for Canal-JSON.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

pingcap/tiflow#10014

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2023
@3AceShowHand
Copy link
Contributor Author

该功能已经在 master，未进入 7.5.0 版本。

cherry-pick 回去 6.5.6， 7.1.3, 7.5.1

@Oreoxmt Oreoxmt self-assigned this Nov 30, 2023
@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. translation/doing This PR’s assignee is translating this PR. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. labels Nov 30, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 30, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 30, 2023

@nongfushanquan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Oreoxmt and others added 2 commits November 30, 2023 16:49
@Oreoxmt
update the order
17e16cf 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@3AceShowHand
Merge pull request #1 from Oreoxmt/review-15579
0a88caf 
update the structure
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 30, 2023
@Oreoxmt Oreoxmt requested a review from qiancai November 30, 2023 08:54
qiancai
qiancai approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ticdc/ticdc-canal-json.md Outdated Show resolved Hide resolved
ticdc/ticdc-canal-json.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 30, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 30, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-30 08:54:51.911756082 +0000 UTC m=+1085720.576982279: ☑️ agreed by Oreoxmt.
  • 2023-11-30 09:17:00.906669227 +0000 UTC m=+1087049.571895423: ☑️ agreed by qiancai.

@Oreoxmt @qiancai
Apply suggestions from code review
0e16a11 
Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt Oreoxmt mentioned this pull request Nov 30, 2023
Merged
18 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 30, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Dec 7, 2023

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit a874ae8 into pingcap:master Dec 7, 2023
6 of 7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #15610.

This was referenced Dec 7, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 7, 2023
@ti-chi-bot
cdc: add description about canal-json content-compatible. (#15579) (#…
7c0cccc 
…15610)
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Dec 18, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #15795.

This was referenced Dec 18, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2023
@ti-chi-bot
cdc: add description about canal-json content-compatible. (#15579) (#…
3e2556e 
…15795)
@Oreoxmt Oreoxmt mentioned this pull request Jan 12, 2024
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai qiancai approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@3AceShowHand @Oreoxmt @ti-chi-bot @qiancai @nongfushanquan