Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codec(ticdc): canal-json support compatible content by output detailed mysql type information #10014

Merged
merged 38 commits into from
Nov 20, 2023
Merged

codec(ticdc): canal-json support compatible content by output detailed mysql type information #10014

merged 38 commits into from
Nov 20, 2023

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Nov 6, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10106

What is changed and how it works?

  1. add content-compatible to the sink-uri to control canal-json output MySQL type information.
  2. Canal-JSON can output detailed MySQL type information if the content-compatible is set to true.
  3. Canal-JSON only output handle key updated columns if the content-compatible is true.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2023
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 20, 2023
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-storage-test

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-20 06:56:58.87350605 +0000 UTC m=+214647.538732244: ☑️ agreed by nongfushanquan.
  • 2023-11-20 07:41:04.422848453 +0000 UTC m=+217293.088074633: ☑️ agreed by asddongmen.

@ti-chi-bot ti-chi-bot bot merged commit 4a3762c into pingcap:master Nov 20, 2023
14 checks passed
@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-6.5: #10126.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#10014
f930678 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-7.1: #10128.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 22, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 22, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#10014
880af81 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 24, 2023
@ti-chi-bot
codec(ticdc): canal-json support compatible content by output detaile…
587b155 
…d mysql type information (#10014) (#10126)

close #10106
@3AceShowHand 3AceShowHand mentioned this pull request Nov 30, 2023
Merged
18 tasks
@Oreoxmt Oreoxmt mentioned this pull request Nov 30, 2023
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2023
@ti-chi-bot
codec(ticdc): canal-json support compatible content by output detaile…
3f6e111 
…d mysql type information (#10014) (#10128)

close #10106
This was referenced Dec 7, 2023
Merged
Merged
This was referenced Dec 18, 2023
Merged
Merged
@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-7.5: #11415.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 25, 2024
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#10014
72e8486 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 25, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jul 26, 2024
@ti-chi-bot
codec(ticdc): canal-json support compatible content by output detaile…
c7a5513 
…d mysql type information (#10014) (#11415)

close #10106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

@CharlesCheung96 CharlesCheung96 Awaiting requested review from CharlesCheung96

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

canal-json support comptabile content by output detailed mysql type information.
4 participants
@3AceShowHand @ti-chi-bot @asddongmen @nongfushanquan