Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-lightning: add block-size #16231

Merged
merged 4 commits into from
Jan 22, 2024
Merged

tidb-lightning: add block-size #16231

merged 4 commits into from
Jan 22, 2024

Conversation

lyzx2001
Copy link
Contributor

@lyzx2001 lyzx2001 commented Jan 22, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add configuration parameter TikvImporter.BlockSize.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2024
@lyzx2001
Copy link
Contributor Author

/cc @hfxsd

@ti-chi-bot ti-chi-bot bot requested a review from hfxsd January 22, 2024 04:56
@lyzx2001
Copy link
Contributor Author

/cc @lance6716

@ti-chi-bot ti-chi-bot bot requested a review from lance6716 January 22, 2024 04:57
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.6 This PR/issue applies to TiDB v7.6. and removed missing-translation-status This PR does not have translation status info. labels Jan 22, 2024
@hfxsd hfxsd self-assigned this Jan 22, 2024
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@hfxsd hfxsd changed the title Update tidb-lightning-configuration.md tidb-lightning: add block-size Jan 22, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 22, 2024
@hfxsd hfxsd requested a review from ran-huang January 22, 2024 05:15
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2024
Copy link

ti-chi-bot bot commented Jan 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-22 05:14:31.493569415 +0000 UTC m=+764913.057867120: ☑️ agreed by hfxsd.
  • 2024-01-22 05:31:43.102825611 +0000 UTC m=+765944.667123316: ☑️ agreed by lance6716.

@hfxsd
Copy link
Collaborator

hfxsd commented Jan 22, 2024

/approve

Copy link

ti-chi-bot bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 22, 2024
@hfxsd hfxsd added the for-release This PR relates to a TiDB release but does not have a tracked feature. label Jan 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit b288c49 into master Jan 22, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the lyzx2001-patch-1 branch January 22, 2024 13:18
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16241.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.6 This PR/issue applies to TiDB v7.6.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants