Lightning : make pebbleDB block size configurable

[mittalrishabh]

What problem does this PR solve?

Issue Number: close #45037

Problem Summary:
We have seen that lightning is bounded by EBS IOPS which is 16k and is taking more than 3 hours to transfer 7 TB of data.

What changed and how does it work?

I have made the block size configurable through lightning config. We are setting it 128k internally.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Its running in production with 128k size. However, i haven't tested the master code. I am relying on pingcap CI to test it.
Side effects

I haven't seen much increase in memory and CPU after increasing the block size.
Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

Hi @mittalrishabh. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @mittalrishabh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance6716]

/ok-to-test

[lance6716]

/cc @lyzx2001

[codecov]

Codecov Report

Merging #49514 (b647d7e) into master (999f599) will decrease coverage by 3.2133%.
The diff coverage is 0.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #49514        +/-   ##
================================================
- Coverage   72.0620%   68.8487%   -3.2133%     
================================================
  Files          1438       1440         +2     
  Lines        345762     407290     +61528     
================================================
+ Hits         249163     280414     +31251     
- Misses        76461     107965     +31504     
+ Partials      20138      18911      -1227     

Flag	Coverage Δ
integration	43.8687% <0.0000%> (?)
unit	72.0505% <ø> (-0.0115%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	56.3129% <ø> (ø)
parser	∅ <ø> (∅)
br	44.1967% <0.0000%> (-7.5061%)	⬇️

[wuhuizuo]

/retest

[lyzx2001]

also need to add the code to check whether BlockSize is valid before using it

[lyzx2001]

/cc @lance6716

[lance6716]

/test pull-lightning-integration-test

[tiprow]

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lance6716]

rest lgtm

[lance6716]

In order to keep compatibility, we should use the old effective value 16 * 1024, as in newSSTWriter from backend/local/engine.go line 1377

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• br/pkg/lightning/OWNERS [lance6716]
• pkg/ddl/OWNERS [tangenta,ywqzzy]
• pkg/executor/importer/OWNERS [lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lance6716]

/unhold

[lance6716]

/test pull-lightning-integration-test

[tiprow]

@lance6716: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #51931.