tidb-in-kubernetes: update offline pump doc #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junlan-zhang
added
the
translation/done
weekface
approved these changes
Oct 14, 2019
lilin90
reviewed
Oct 15, 2019
| @@ -139,31 +139,29 @@ kubectl get pvc -n <namespace> -l app.kubernetes.io/component=backup,pingcap.com | |||
|
|
|||
| ### Pump 缩容 | |||
|
|
|||
| 缩容 Pump 需要挨个先将 Pump 节点从集群中下线之后操作 `helm upgrade` 进行缩容。 | |||
| 缩容 Pump 需要**挨个**将 Pump 节点从集群中下线，然后操作 `helm upgrade` 将对应的 Pump Pod 删除。 | |||
There was a problem hiding this comment.
Suggested change
| 缩容 Pump 需要**挨个**将 Pump 节点从集群中下线，然后操作 `helm upgrade` 将对应的 Pump Pod 删除。 | |
| 缩容 Pump 需要先将 Pump 节点从集群中**逐一**下线，然后操作 `helm upgrade` 将对应的 Pump Pod 删除。 |
There was a problem hiding this comment.
To scale in Pump, for each Pump node, make the node offline and delete the corresponding Pump Pod instead of making all the unwanted nodes offline and deleting the corresponding Pump Pods.
To make it clearer, how about "缩容 Pump 需要先将单个 Pump 节点从集群中下线，然后操作 helm upgrade 将对应的 Pump Pod 删除，并对每个节点重复上述步骤。"?
| @@ -140,31 +140,29 @@ kubectl get pvc -n <namespace> -l app.kubernetes.io/component=backup,pingcap.com | |||
|
|
|||
| ### Pump 缩容 | |||
|
|
|||
| 缩容 Pump 需要挨个先将 Pump 节点从集群中下线之后操作 `helm upgrade` 进行缩容。 | |||
| 缩容 Pump 需要**挨个**将 Pump 节点从集群中下线，然后操作 `helm upgrade` 将对应的 Pump Pod 删除。 | |||
There was a problem hiding this comment.
Suggested change
| 缩容 Pump 需要**挨个**将 Pump 节点从集群中下线，然后操作 `helm upgrade` 将对应的 Pump Pod 删除。 | |
| 缩容 Pump 需要先将 Pump 节点从集群中**逐一**下线，然后操作 `helm upgrade` 将对应的 Pump Pod 删除。 |
yikeke
reviewed
Oct 18, 2019
| @@ -139,31 +139,29 @@ kubectl get pvc -n <namespace> -l app.kubernetes.io/component=backup,pingcap.com | |||
|
|
|||
| ### Pump 缩容 | |||
|
|
|||
| 缩容 Pump 需要挨个先将 Pump 节点从集群中下线之后操作 `helm upgrade` 进行缩容。 | |||
| 缩容 Pump 需要先将单个 Pump 节点从集群中下线，然后操作 helm upgrade 将对应的 Pump Pod 删除，并对每个节点重复上述步骤。 | |||
There was a problem hiding this comment.
Suggested change
| 缩容 Pump 需要先将单个 Pump 节点从集群中下线，然后操作 helm upgrade 将对应的 Pump Pod 删除，并对每个节点重复上述步骤。 | |
| 缩容 Pump 需要先将单个 Pump 节点从集群中下线，然后运行 `helm upgrade` 命令将对应的 Pump Pod 删除，并对每个节点重复上述步骤。 |
|
PTAL @yikeke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted?
What is the related PR or file link(s)?
#1757
Which version does your change affect?
dev, v3.0