Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidb-in-kubernetes: add offline pump document #1757

Merged
merged 7 commits into from
Aug 20, 2019
Merged

tidb-in-kubernetes: add offline pump document #1757

merged 7 commits into from
Aug 20, 2019

Conversation

weekface
Copy link
Contributor

What is changed, added or deleted?

What is the related PR or file link(s)?

Which version does your change affect?

Checklist

  • Add a new file to TOC.md
  • No Tab spaces anywhere
  • Leave a blank line both before and after a code block
  • Keep the first level heading consistent with title in metadata
  • Use four spaces for each level of indentation except that in TOC.md

@weekface
Copy link
Contributor Author

@lilin90 PTAL

@weekface
Copy link
Contributor Author

Do not merge before pingcap/tidb-operator#769

tennix
tennix approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added translation/doing This PR’s assignee is translating this PR. tidb-in-k8s labels Aug 16, 2019
yikeke
yikeke approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke self-assigned this Aug 20, 2019
@yikeke yikeke merged commit a1c1269 into pingcap:master Aug 20, 2019
@yikeke yikeke removed their assignment Aug 20, 2019
@weekface weekface deleted the offline-pump branch September 27, 2019 10:16
@junlan-zhang junlan-zhang mentioned this pull request Sep 27, 2019
Merged
@junlan-zhang junlan-zhang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Sep 27, 2019
@junlan-zhang junlan-zhang mentioned this pull request Oct 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@yikeke yikeke yikeke approved these changes

@lilin90 lilin90 Awaiting requested review from lilin90

Assignees

@junlan-zhang junlan-zhang

Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weekface @tennix @yikeke @lilin90 @junlan-zhang