Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-in-kubernetes: add offline pump document #1555

Merged
merged 20 commits into from
Oct 14, 2019

Conversation

junlan-zhang
Copy link
Contributor

What is changed, added or deleted?

  • Add offline pump document

What is the related PR or file link(s)?

pingcap/docs-cn#1757

Which version does your change affect?

dev, v3.0

@junlan-zhang junlan-zhang added area/tidb-in-k8s-v1.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Sep 27, 2019
@@ -126,3 +126,35 @@ The `pingcap/tidb-backup` helm chart helps restore a TiDB cluster using backup d
Incremental backup uses [TiDB Binlog](/dev/reference/tidb-binlog-overview.md) to collect binlog data from TiDB and provide real-time backup and replication to downstream platforms.

For the detailed guide of maintaining TiDB Binlog in Kubernetes, refer to [TiDB Binlog](/dev/tidb-in-kubernetes/maintain/tidb-binlog.md).

### Decrease the capability of Pump
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Scale down instead of Decrease the capability of?

@junlan-zhang
Copy link
Contributor Author

PTAL @yikeke

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for v3.0~ Rest LGTM


### Scale Pump in

To decrease the capability of Pump, make Pump nodes offline and then run the `helm upgrade` command to delete Pump pods.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To decrease the capability of Pump, make Pump nodes offline and then run the `helm upgrade` command to delete Pump pods.
To scale Pump in, you decrease the number of Pump nodes by taking the nodes offline one at a time and running the `helm upgrade` command to delete the corresponding Pump Pod. The steps are as follows:

"Pod" needs to be capitalized. ref: https://kubernetes.io/docs/concepts/workloads/pods/pod-overview/


To decrease the capability of Pump, make Pump nodes offline and then run the `helm upgrade` command to delete Pump pods.

1. Make Pump nodes offline from the TiDB cluster
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Make Pump nodes offline from the TiDB cluster
1. Make the Pump node offline from the TiDB cluster


1. Make Pump nodes offline from the TiDB cluster

Suppose there are 3 Pump nodes, and you want to get the third node offline and modify `<ordinal-id>` to `2`, run the following command. `<version>` is the current version of TiDB.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Suppose there are 3 Pump nodes, and you want to get the third node offline and modify `<ordinal-id>` to `2`, run the following command. `<version>` is the current version of TiDB.
Suppose there are 3 Pump nodes, and you want to get the third node offline and modify `<ordinal-id>` to `2`, run the following command (`<version>` is the current version of TiDB).

kubectl logs -f -n <namespace> <release-name>-pump-<ordinal-id>
```

2. Delete Pump pods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Delete Pump pods
2. Delete the corresponding Pump Pod


2. Delete Pump pods

Modify `binlog.pump.replicas` in the `values.yaml` file to `2` and then, run the following command to delete Pump pods.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Modify `binlog.pump.replicas` in the `values.yaml` file to `2` and then, run the following command to delete Pump pods.
Modify `binlog.pump.replicas` in the `values.yaml` file to `2` and then run the following command to delete the Pump Pod.

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PTAL again. @weekface

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit b1dcb66 into pingcap:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tidb-in-k8s-v1.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants