Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: change all "http" to "https" in http://download.pingcap.org/ #2165

Merged
merged 2 commits into from
Jan 7, 2020
Merged

*: change all "http" to "https" in http://download.pingcap.org/ #2165

merged 2 commits into from
Jan 7, 2020

Conversation

n0vad3v
Copy link
Contributor

@n0vad3v n0vad3v commented Jan 6, 2020

What is changed, added or deleted?

Change Every http://download.pingcap.org/ to https://download.pingcap.org/.

There is no 301 redirect from HTTP to HTTPS on download.pingcap.org, fixing this would significantly improve security on downloading from our sites.

What is the related PR or file link(s)?

N/A

Which version does your change affect?

ALL

@claassistantio
Copy link

claassistantio commented Jan 6, 2020

CLA assistant check
All committers have signed the CLA.

@lilin90 lilin90 changed the title Change Every http://download.pingcap.org/ to https://download.pingcap.org/. *: change all "http" to "https" in http://download.pingcap.org/ Jan 6, 2020
@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Jan 6, 2020
@WangXiangUSTC
Copy link
Contributor

LGTM

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added the size/medium Changes of a medium size. label Jan 7, 2020
@lilin90 lilin90 merged commit a4db3fc into pingcap:master Jan 7, 2020
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium Changes of a medium size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants