Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-lightning: document backend and that system DBs are filtered #2184

Merged
merged 5 commits into from
Feb 11, 2020

Conversation

anotherrachel
Copy link
Contributor

@anotherrachel anotherrachel commented Jan 14, 2020

What is changed, added or deleted?

This PR

What is the related PR or file link(s)?

pingcap/docs#1620
pingcap/docs#1693 (update glossary in #2214)

Which version does your change affect?

dev, v3.0 and v3.1

@anotherrachel anotherrachel added DNM translation/from-docs This PR is translated from a PR in pingcap/docs. requires-followup This PR requires a follow-up task after being merged. labels Jan 14, 2020
@anotherrachel anotherrachel force-pushed the lightning-backend branch 2 times, most recently from 80381d5 to 163c594 Compare January 14, 2020 08:20
@anotherrachel anotherrachel marked this pull request as ready for review January 14, 2020 08:28
@anotherrachel
Copy link
Contributor Author

@kennytm @yikeke PTAL, thanks!

@anotherrachel anotherrachel removed the requires-followup This PR requires a follow-up task after being merged. label Feb 6, 2020
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor edits. Rest LGTM. Good job!

dev/faq/tidb-lightning.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/config.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/deployment.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb-backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb-backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb-backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb-backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb-backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb-backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb-backend.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dev/TOC.md Show resolved Hide resolved
dev/reference/tools/tidb-lightning/config.md Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb-backend.md Outdated Show resolved Hide resolved
@anotherrachel anotherrachel added v3.0 and removed translation/from-docs This PR is translated from a PR in pingcap/docs. labels Feb 11, 2020
@anotherrachel
Copy link
Contributor Author

@yikeke @kennytm v3.0 and v3.1 updated. PTAL, thanks!

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anotherrachel anotherrachel removed the DNM label Feb 11, 2020
@anotherrachel anotherrachel merged commit de4cffc into pingcap:master Feb 11, 2020
@WangXiangUSTC
Copy link
Contributor

why ignore v2.1?

@kennytm
Copy link
Contributor

kennytm commented Feb 11, 2020

Most of these features do not exist in 2.1.

@anotherrachel anotherrachel deleted the lightning-backend branch February 18, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants