Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix sequence doc #2380

Merged
merged 11 commits into from
Mar 11, 2020
Merged

sql: fix sequence doc #2380

merged 11 commits into from
Mar 11, 2020

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Mar 5, 2020

What is changed, added or deleted? (Required)

Add a description of how does TiDB setval differ from Maraidb.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version, including v4.0 changes for now)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn changed the title dev: fix sequence doc sql: fix sequence doc Mar 5, 2020
@TomShawn TomShawn self-assigned this Mar 5, 2020
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. labels Mar 5, 2020
reference/sql/statements/create-sequence.md Show resolved Hide resolved
reference/sql/statements/create-sequence.md Outdated Show resolved Hide resolved
reference/sql/statements/create-sequence.md Outdated Show resolved Hide resolved
reference/sql/statements/create-sequence.md Outdated Show resolved Hide resolved
reference/sql/statements/create-sequence.md Outdated Show resolved Hide resolved
reference/sql/statements/create-sequence.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

TomShawn commented Mar 5, 2020

@AilinKid #2282 中新增的三篇 SEQUENCE 文档需要添加到 TOC 吗?

@TomShawn TomShawn added the v4.0 This PR/issue applies to TiDB v4.0. label Mar 5, 2020
@AilinKid
Copy link
Contributor Author

AilinKid commented Mar 5, 2020

文档需要添加到 TOC 吗?

需要的,谢谢哈

@TomShawn
Copy link
Contributor

TomShawn commented Mar 5, 2020

LGTM
@AilinKid Please involve a technical review, thanks!

@TomShawn TomShawn added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 5, 2020
TOC.md Outdated Show resolved Hide resolved
TOC.md Outdated Show resolved Hide resolved
TOC.md Show resolved Hide resolved
reference/sql/statements/create-sequence.md Outdated Show resolved Hide resolved
Comment on lines 283 to 287
```
1, 3, 5, ... // 序列遵循起始为 1、步长为 2 的等差关系。
select setval(seq, 6) // 设置 SEQUENCE 的当前值为 6。
7, 9, 11, ... // 后续产生值仍会遵循这个等差关系。
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use some SQLs to indicate this.
e.g. select nextval...(show output) ; select setval ....; select nextval ...(show output).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is ok, this wants to explain the logic of the numbers, using the SQL show here will be a huge page.

@AilinKid
Copy link
Contributor Author

Thank you so much @TomShawn for this.
PTAL @djshow832

@TomShawn TomShawn mentioned this pull request Mar 11, 2020
4 tasks
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djshow832 djshow832 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2020
@TomShawn TomShawn removed the translation/doing This PR’s assignee is translating this PR. label Mar 11, 2020
@TomShawn TomShawn added status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Mar 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 11, 2020

/run-all-tests

@sre-bot sre-bot merged commit 5325000 into pingcap:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement. v4.0 This PR/issue applies to TiDB v4.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants