Skip to content

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Mar 11, 2020

What is changed, added or deleted? (Required)

Add SEQUENCE documents

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version, including v4.0 changes for now)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0. size/large Changes of a large size. labels Mar 11, 2020
@TomShawn TomShawn added the status/WIP This PR is still working in progress. label Mar 14, 2020
@TomShawn TomShawn removed the status/WIP This PR is still working in progress. label Mar 24, 2020
@TomShawn TomShawn requested a review from AilinKid March 24, 2020 12:51
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn requested a review from yikeke March 25, 2020 08:42
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

TomShawn and others added 3 commits March 27, 2020 16:24
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
@TomShawn
Copy link
Contributor Author

@yikeke All comments are addressed, PTAL again, thanks!

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 27, 2020

/run-all-tests

@sre-bot sre-bot merged commit 66c22ad into pingcap:master Mar 27, 2020
@TomShawn TomShawn deleted the sequence-docs branch March 27, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants