-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: check connectivity of external links via GitHub action #4464
Conversation
除了这个问题,又发现了个问题:目前报的有些链接有些是 false alarms,比如 |
只能用 regex |
The |
This reverts commit 003f981.
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-2.1 in PR #4783 |
/run-cherry-picker |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.0 in PR #4784 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-3.1 in PR #4785 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #4786 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
… (#4783) * cherry pick #4464 to release-2.1 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * Update sql-statement-admin.md * Update tune-operating-system.md * test * timeout 10s * Update tune-operating-system.md * Update tidb-faq.md * timeout 60s * timout 20s * Update tidb-faq.md Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com>
What is changed, added or deleted? (Required)
A migration from pingcap/docs-dm#353
Note this external link check isn't required to pass, in order to prevent false alarms from blocking PR merge.
The current regex exclusions is:
http://172.*|https://github.com/.*/pull/.*|https://github.com/.*/issues/.*|https://github.com/[^.\n]*$|http://127.0.0.1.*|http://localhost.*|http://.*:.*|https://static.googleusercontent.com/media/research.google.com/.*|.*.md
Meaning the check will skip checking the URLs matching the above patterns.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?