Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: check connectivity of external links via GitHub action (#4135) #4137

Merged
merged 4 commits into from
Nov 3, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #4135 to release-3.0


What is changed, added or deleted? (Required)

A migration from pingcap/docs-dm#353

Note this external link check isn't required to pass, in order to prevent false alarms from blocking PR merge.

The current regex exclusions is:

http://172.*|https://github.com/.*/pull/.*|https://github.com/.*/issues/.*|https://github.com/[^.\n]*$|http://127.0.0.1.*|http://localhost.*|http://.*:.*|https://static.googleusercontent.com/media/research.google.com/.*|.*.md

Meaning the check will skip checking the URLs matching the above patterns.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added the type/cherry-pick-for-release-3.0 This PR is cherry-picked to release-3.0 from a source PR. label Nov 3, 2020
@ti-srebot
Copy link
Contributor Author

@yikeke please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs/invitations

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2020
@yikeke yikeke merged commit ea445ad into pingcap:release-3.0 Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-3.0 This PR is cherry-picked to release-3.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants