Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs about logs #4575

Merged
merged 16 commits into from
Nov 2, 2020
Merged

update docs about logs #4575

merged 16 commits into from
Nov 2, 2020

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 23, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Update docs about explain-analyze and slow logs.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn self-assigned this Sep 24, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Sep 24, 2020
@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Sep 25, 2020
@ti-srebot
Copy link
Contributor

@crazycs520, @SunRunAway, PTAL.

@ti-srebot
Copy link
Contributor

@qw4990, please update your pull request.

@ti-srebot
Copy link
Contributor

@crazycs520, @SunRunAway, PTAL.

@ti-srebot
Copy link
Contributor

@qw4990, please update your pull request.

@ti-srebot
Copy link
Contributor

@crazycs520, @SunRunAway, PTAL.

@ti-srebot
Copy link
Contributor

@qw4990, please update your pull request.

1 similar comment
@ti-srebot
Copy link
Contributor

@qw4990, please update your pull request.

@ti-srebot
Copy link
Contributor

No updates for a long time, close PR.

@ti-srebot
Copy link
Contributor

@qw4990, please update your pull request.

1 similar comment
@ti-srebot
Copy link
Contributor

@qw4990, please update your pull request.

@qw4990 qw4990 changed the title update docs about explain-analyze and slow logs update docs about logs Oct 15, 2020
TomShawn
TomShawn reviewed Oct 26, 2020
View reviewed changes
identify-slow-queries.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Oct 26, 2020
View reviewed changes
identify-slow-queries.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Oct 26, 2020
View reviewed changes
identify-slow-queries.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Oct 26, 2020
View reviewed changes
identify-slow-queries.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Oct 26, 2020
View reviewed changes
identify-slow-queries.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@crazycs520, @SunRunAway, @ti-srebot, @TomShawn, PTAL.

@ti-srebot
Copy link
Contributor

@qw4990, please update your pull request.

@ti-srebot
Copy link
Contributor

@crazycs520, @SunRunAway, @ti-srebot, @TomShawn, PTAL.

@ti-srebot
Copy link
Contributor

@qw4990, please update your pull request.

@ti-srebot
Copy link
Contributor

@crazycs520, @SunRunAway, @ti-srebot, @TomShawn, PTAL.

@ti-srebot
Copy link
Contributor

@qw4990, please update your pull request.

@ti-srebot
Copy link
Contributor

No updates for a long time, close PR.

TomShawn and others added 4 commits November 2, 2020 13:25
@TomShawn
Merge branch 'master' into explain-slow-log
8cf2f0b
@qw4990 @TomShawn
Update identify-slow-queries.md
a08c684 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qw4990 @TomShawn
Update identify-slow-queries.md
b288d54 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qw4990 @TomShawn
Update identify-slow-queries.md
fd7b645 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Nov 2, 2020
TomShawn
TomShawn approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Nov 2, 2020
@TomShawn TomShawn merged commit c1b71f2 into pingcap:master Nov 2, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Nov 2, 2020
@qw4990 @ti-srebot
cherry pick pingcap#4575 to release-4.0
eda906a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 2, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4773

TomShawn pushed a commit that referenced this pull request Nov 2, 2020
@ti-srebot @qw4990
cherry pick #4575 to release-4.0 (#4773)
18ac68d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Yuanjia Zhang <zhangyuanjia@pingcap.com>
@TomShawn TomShawn mentioned this pull request Nov 5, 2020
Merged
9 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 5, 2020
@ti-srebot ti-srebot mentioned this pull request Nov 19, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@crazycs520 crazycs520 crazycs520 left review comments

@TomShawn TomShawn TomShawn approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees

@TomShawn TomShawn

Labels
size/small Changes of a small size. status/LGT3 The PR has already had 3 LGTM. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @ti-srebot @SunRunAway @crazycs520 @TomShawn