-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: make the format of user and host fields in slow logs be compatible with MySQL #18162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thx @crazycs520 , PTAL @SunRunAway @XuHuaiyu |
/rebuild |
/run-unit-test |
1 similar comment
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #18162 +/- ##
===========================================
Coverage 79.4716% 79.4716%
===========================================
Files 536 536
Lines 145394 145394
===========================================
Hits 115547 115547
Misses 20576 20576
Partials 9271 9271 |
/run-unit-test |
1 similar comment
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SunRunAway,Thanks for your review. |
/merge |
/run-all-tests |
@qw4990 merge failed. |
/rebuild |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #18379 |
What problem does this PR solve?
Issue Number: related to #17846
Problem Summary: make the format of user and host fields in slow logs be compatible with MySQL
What is changed and how it works?
The format of TiDB now is:
# User: {user_name}@{host_address}
For example:
# User: root@127.0.0.1
After this PR, it will be:
# User@Host: {user_name}[{user_name}] @ {host_name} [{host_address}]
, which is compatible with MySQL.For example:
# User@Host: root[root] @ localhost [127.0.0.1]
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Release note