executor: make the format of user and host fields ... (#18162) #18379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
sig/sql-infra
SunRunAway
reviewed
Jul 6, 2020
executor/slow_query_test.go
Outdated
| @@ -76,7 +77,11 @@ select * from t;` | |||
| } | |||
| recordString += str | |||
| } | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Please resolve this conflict.
|
PTAL @zz-jason @SunRunAway |
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
zz-jason
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18162 to release-4.0
What problem does this PR solve?
Issue Number: related to #17846
Problem Summary: make the format of user and host fields in slow logs be compatible with MySQL
What is changed and how it works?
The format of TiDB now is:
# User: {user_name}@{host_address}For example:
# User: root@127.0.0.1After this PR, it will be:
# User@Host: {user_name}[{user_name}] @ {host_name} [{host_address}], which is compatible with MySQL.For example:
# User@Host: root[root] @ localhost [127.0.0.1]Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note