Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Type system differences" for MySQL Compatibility #4765

Merged
merged 4 commits into from
Nov 2, 2020
Merged

Update "Type system differences" for MySQL Compatibility #4765

merged 4 commits into from
Nov 2, 2020

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Nov 2, 2020

What is changed, added or deleted? (Required)

The "Type system differences" section was updated as it TiDB supports some of the types that were listed as unsupported.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Nov 2, 2020

/label, need-cheery-pick-4.0, size/small, translation/from-docs

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Nov 2, 2020

/cc TomShawn

@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Nov 2, 2020
TomShawn
TomShawn approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Nov 2, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@TomShawn TomShawn merged commit 7a61c18 into pingcap:master Nov 2, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Nov 2, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#4765 to release-4.0
b62cffc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 2, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4770

TomShawn pushed a commit that referenced this pull request Nov 2, 2020
@ti-srebot @Joyinqin
cherry pick #4765 to release-4.0 (#4770)
e6684c5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joyinqin @ti-srebot @TomShawn