-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Type system differences" for MySQL Compatibility #4115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiDB: ``` mysql> SELECT tidb_version()\G *************************** 1. row *************************** tidb_version(): Release Version: v4.0.8 Edition: Community Git Commit Hash: 66ac9fc31f1733e5eb8d11891ec1b38f9c422817 Git Branch: heads/refs/tags/v4.0.8 UTC Build Time: 2020-10-30 08:21:16 GoVersion: go1.13 Race Enabled: false TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306 Check Table Before Drop: false 1 row in set (0.00 sec) mysql> CREATE TABLE t1 (id SERIAL, y SQL_TSI_YEAR, f FIXED(4,2)); Query OK, 0 rows affected (0.11 sec) mysql> SHOW CREATE TABLE t1\G *************************** 1. row *************************** Table: t1 Create Table: CREATE TABLE `t1` ( `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT, `y` year(4) DEFAULT NULL, `f` decimal(4,2) DEFAULT NULL, UNIQUE KEY `id` (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin 1 row in set (0.01 sec) ``` MySQL: ``` mysql> SELECT VERSION(); +-----------+ | VERSION() | +-----------+ | 8.0.20 | +-----------+ 1 row in set (0.00 sec) mysql> CREATE TABLE t1 (id SERIAL, y SQL_TSI_YEAR, f FIXED(4,2)); Query OK, 0 rows affected (0.06 sec) mysql> SHOW CREATE TABLE t1\G *************************** 1. row *************************** Table: t1 Create Table: CREATE TABLE `t1` ( `id` bigint unsigned NOT NULL AUTO_INCREMENT, `y` year DEFAULT NULL, `f` decimal(4,2) DEFAULT NULL, UNIQUE KEY `id` (`id`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci 1 row in set (0.00 sec) ```
ti-srebot
added
the
first-time-contributor
Indicates that the PR was contributed by an external member and is a first-time contributor.
label
Oct 30, 2020
ghost
added
the
needs-cherry-pick-4.0
label
Oct 30, 2020
LGTM |
TomShawn
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dveeden Thanks!
ti-srebot
approved these changes
Nov 2, 2020
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Nov 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
cherry pick to release-4.0 in PR #4118 |
TomShawn
pushed a commit
that referenced
this pull request
Nov 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Daniël van Eeden <github@myname.nl>
/label translation/done |
ti-srebot
added
the
translation/done
This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
label
Nov 2, 2020
/unlabel translation/doing |
ti-srebot
removed
the
translation/doing
This PR's assignee is translating this PR.
label
Nov 2, 2020
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
first-time-contributor
Indicates that the PR was contributed by an external member and is a first-time contributor.
size/small
Changes of a small size.
status/LGT2
Indicates that a PR has LGTM 2.
translation/done
This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
The "Type system differences" section was updated as it TiDB supports some of the types that were listed as unsupported.
TiDB:
MySQL:
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?