Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql-compatibility: update ZERO_DATE docs #5154

Merged
merged 2 commits into from
Dec 31, 2020
Merged

mysql-compatibility: update ZERO_DATE docs #5154

merged 2 commits into from
Dec 31, 2020

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Dec 23, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

The behavior of zero_date changed in master to be more mysql compatibility. This has not been backported.

There are some minor exceptions still, since DDL changes can still produce invalid dates (see: pingcap/tidb#21564 ). But I think these are minor, and it is worth updating the docs since the main workflow as described (INSERT/UPDATE) now matches MySQL.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Joyinqin
Copy link
Contributor Author

/label size/small, translation/from-docs

@ti-srebot ti-srebot added size/small Changes of a small size. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Dec 23, 2020
@Joyinqin
Copy link
Contributor Author

/cc TomShawn

TomShawn
TomShawn approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2020
@TomShawn TomShawn merged commit f5e477b into pingcap:master Dec 31, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Dec 31, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#5154 to release-5.0
fbd792e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 31, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5233

TomShawn pushed a commit that referenced this pull request Dec 31, 2020
@ti-srebot @Joyinqin
cherry pick #5154 to release-5.0 (#5233)
df96241 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joyinqin @ti-srebot @TomShawn