Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server.request-batch-enable-cross-command is obsolete in v5 #6107

Merged
merged 1 commit into from
Apr 22, 2021
Merged

server.request-batch-enable-cross-command is obsolete in v5 #6107

merged 1 commit into from
Apr 22, 2021

Conversation

dbsid
Copy link
Contributor

@dbsid dbsid commented Apr 21, 2021 •
edited
Loading

remove the config from v5.0, otherwise the TiKV can not startup

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dbsid
server.request-batch-enable-cross-command is obsolete in v5
4ba5a31 
remove the config from v5.0, otherwise the TiKV can not startup
@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Apr 21, 2021
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Apr 21, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 21, 2021
@TomShawn
Copy link
Contributor

/label needs-cherry-pick-master
/translation from-docs

@ti-chi-bot ti-chi-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-master Should cherry pick this PR to master branch. and removed missing-translation-status This PR does not have translation status info. labels Apr 22, 2021
@TomShawn
Copy link
Contributor

This PR is translated from pingcap/docs#5414.

@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ba5a31

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2021
@ti-chi-bot ti-chi-bot merged commit a995f59 into pingcap:release-5.0 Apr 22, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 22, 2021
@dbsid @ti-srebot
cherry pick pingcap#6107 to master
17cfe97 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 22, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #6110

ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
@ti-srebot
server.request-batch-enable-cross-command is obsolete in v5 (#6107) (#…
855da99 
…6110)
@TomShawn TomShawn mentioned this pull request Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dbsid @CLAassistant @TomShawn @ti-chi-bot @ti-srebot