Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no server.request-batch-enable-cross-command in V5.0.0 #5414

Merged
merged 1 commit into from
Apr 21, 2021
Merged

no server.request-batch-enable-cross-command in V5.0.0 #5414

merged 1 commit into from
Apr 21, 2021

Conversation

dbsid
Copy link
Contributor

@dbsid dbsid commented Apr 21, 2021 •
edited
Loading

The parameter prevent the TiKV startup.
unknown configuration options: server.request-batch-enable-cross-command

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dbsid
no server.request-batch-enable-cross-command in V5.0.0
afdc6eb 
The parameter prevent the TiKV startup.
unknown configuration options: server.request-batch-enable-cross-command
@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Apr 21, 2021
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2021
@TomShawn
Copy link
Contributor

/cc @sticnarf @shuke987
/assign @Liuxiaozhen12
/label needs-cherry-pick-master

@ti-chi-bot
Copy link
Member

@TomShawn: GitHub didn't allow me to assign the following users: Liuxiaozhen12.

Note that only pingcap members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/cc @sticnarf @shuke987
/assign @Liuxiaozhen12
/label needs-cherry-pick-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-master Should cherry pick this PR to master branch. label Apr 21, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 21, 2021 •
edited
Loading

/assign @en-jin19
/translation doing

@ti-chi-bot ti-chi-bot added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Apr 21, 2021
@TomShawn
Copy link
Contributor

/uncc @en-jin19
/assign @en-jin19

@ti-chi-bot ti-chi-bot removed the request for review from en-jin19 April 21, 2021 05:32
@TomShawn TomShawn mentioned this pull request Apr 21, 2021
Closed
sticnarf
sticnarf approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@sticnarf: /lgtm is only allowed for the reviewers in list.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/sig transaction docs

@ti-chi-bot ti-chi-bot added area/transaction Indicates that the Issue or PR belongs to the area of transaction. sig/docs Indicates that the Issue or PR belongs to the docs SIG. labels Apr 21, 2021
@ti-chi-bot
Copy link
Member

@shuke987: /lgtm is only allowed for the reviewers in list.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@shuke987
Copy link
Contributor

LGTM

@shuke987
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@shuke987: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: afdc6eb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2021
@ti-chi-bot ti-chi-bot merged commit 18f26a0 into pingcap:release-5.0 Apr 21, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 21, 2021
@dbsid @ti-srebot
cherry pick pingcap#5414 to master
2accf83 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 21, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #5420

ti-chi-bot pushed a commit that referenced this pull request Apr 21, 2021
@ti-srebot
no server.request-batch-enable-cross-command in V5.0.0 (#5414) (#5420)
e943feb
@TomShawn
Copy link
Contributor

/remove-translation doing
/translation done
/unassign @en-jin19
/assign @dbsid

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 22, 2021
@ti-chi-bot ti-chi-bot removed the translation/doing This PR's assignee is translating this PR. label Apr 22, 2021
@TomShawn TomShawn mentioned this pull request Apr 22, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuke987 shuke987 shuke987 approved these changes

@sticnarf sticnarf sticnarf approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@dbsid dbsid

Labels
area/transaction Indicates that the Issue or PR belongs to the area of transaction. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dbsid @TomShawn @ti-chi-bot @shuke987 @ti-srebot @sticnarf @en-jin19