Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment-syntax: Correct the note about --comments #6184

Merged
merged 1 commit into from
Apr 27, 2021
Merged

comment-syntax: Correct the note about --comments #6184

merged 1 commit into from
Apr 27, 2021

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

With the 8.0.23 MySQL client TiDB specific comments are cleared out, so
even with the latest client you still need to add --comments.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from qiancai April 27, 2021 07:08
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2021
@TomShawn
Copy link
Contributor Author

TomShawn commented Apr 27, 2021 •
edited
Loading

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/label require-LGT1
/translation from-docs
/cc @tangenta

@ti-chi-bot
Copy link
Member

@TomShawn: The label(s) translation/from-docs-cn cannot be applied, because the repository doesn't have them.

In response to this:

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/label require-LGT1
/translation from-docs-cn
/cc @tangenta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 27, 2021
@TomShawn
Copy link
Contributor Author

/uncc @qiancai

@ti-chi-bot ti-chi-bot removed the request for review from qiancai April 27, 2021 07:09
@ti-chi-bot ti-chi-bot added translation/from-docs This PR is translated from a PR in pingcap/docs. and removed missing-translation-status This PR does not have translation status info. labels Apr 27, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 76ac1c7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 27, 2021
@ti-chi-bot ti-chi-bot merged commit 97737af into pingcap:master Apr 27, 2021
@TomShawn TomShawn deleted the ocomment-syntaxts branch April 27, 2021 07:12
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 27, 2021
@TomShawn @ti-srebot
cherry pick pingcap#6184 to release-4.0
cc0bebd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #6185

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Apr 27, 2021
@TomShawn @ti-srebot
cherry pick pingcap#6184 to release-5.0
ef9fa66 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #6186

ti-chi-bot pushed a commit that referenced this pull request Apr 27, 2021
@ti-srebot
comment-syntax: Correct the note about --comments (#6184) (#6185)
8d1059c
ti-chi-bot pushed a commit that referenced this pull request Apr 27, 2021
@ti-srebot
comment-syntax: Correct the note about --comments (#6184) (#6186)
69750b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomShawn @ti-chi-bot @ti-srebot @tangenta