Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment-syntax: Correct the note about --comments #5421

Merged
merged 1 commit into from
Apr 22, 2021
Merged

comment-syntax: Correct the note about --comments #5421

merged 1 commit into from
Apr 22, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Apr 21, 2021

What is changed, added or deleted? (Required)

With the 8.0.23 MySQL client TiDB specific comments are cleared out, so
even with the latest client you still need to add --comments.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2021
@tangenta
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2021
TomShawn
TomShawn reviewed Apr 21, 2021
View reviewed changes
comment-syntax.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

/assign @Liuxiaozhen12
/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/translation doing

@ti-chi-bot
Copy link
Member

@TomShawn: GitHub didn't allow me to assign the following users: Liuxiaozhen12.

Note that only pingcap members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Liuxiaozhen12
/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/translation doing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-4.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 21, 2021
@dveeden
comment-syntax: Correct the note about --comments
8681f66 
With the 8.0.23 MySQL client TiDB specific comments are cleared out, so
even with the latest client you still need to add `--comments`.

Related:
- pingcap/tidb#24176 (comment)
@dveeden dveeden force-pushed the tidb_comment_syntax_mysql_client branch from f9475a1 to 8681f66 Compare April 21, 2021 13:25
@TomShawn
Copy link
Contributor

/lgtm
/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 /lgtm.

In response to this:

/lgtm
/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 22, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8681f66

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2021
@ti-chi-bot ti-chi-bot merged commit ed9ed5b into pingcap:master Apr 22, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 22, 2021
@dveeden @ti-srebot
cherry pick pingcap#5421 to release-4.0
fc50624 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 22, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5427

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 22, 2021
@dveeden @ti-srebot
cherry pick pingcap#5421 to release-5.0
9b5bd98 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 22, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5428

ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
@ti-srebot
comment-syntax: Correct the note about --comments (#5421) (#5427)
4966a73
ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
@ti-srebot
comment-syntax: Correct the note about --comments (#5421) (#5428)
fc916b1
@TomShawn
Copy link
Contributor

/assign

@TomShawn TomShawn mentioned this pull request Apr 27, 2021
Merged
10 tasks
@TomShawn
Copy link
Contributor

/remove-translation doing
/translation done

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Apr 27, 2021
This was referenced Apr 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

Assignees

@TomShawn TomShawn

Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dveeden @tangenta @TomShawn @ti-chi-bot @ti-srebot