-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiup: add notice about importing cluster that don't have all nodes mo… #6659
tiup: add notice about importing cluster that don't have all nodes mo… #6659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is also approved by @lucklove.
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/remove-status LGT1 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0bc6825
|
In response to a cherrypick label: new pull request created: #6691. |
In response to a cherrypick label: new pull request created: #6692. |
In response to a cherrypick label: new pull request created: #6693. |
…nitored
First-time contributors' checklist
What is changed, added or deleted? (Required)
Some clusters deployed by TiDB-Ansible may not having monitoring agents deployed on all nodes, and if the user imported the cluster with TiUP Cluster, future operations may fail.
This PR adds a notice to the import doc to guide the user to deploy monitoring agents to all nodes before importing to TiUP Cluster.
This PR changes the manual page of
tiup cluster import
subcommand, I'll file another PR to change the import guidance doc in therelease-4.0
branch.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?