-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiup: add notice about importing cluster (#6108) #6316
tiup: add notice about importing cluster (#6108) #6316
Conversation
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Allen Zhong <allen@moe.cat>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@Liuxiaozhen12: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cb5966f
|
This is an automated cherry-pick of #6108
What is changed, added or deleted? (Required)
Some clusters deployed by TiDB-Ansible may not having monitoring agents deployed on all nodes, and if the user imported the cluster with TiUP Cluster, future operations may fail.
This PR adds a notice to the import doc to guide the user to deploy monitoring agents to all nodes before importing to TiUP Cluster.
This PR changes the manual page of tiup cluster import subcommand, I'll file another PR to change the import guidance doc in the release-4.0 branch.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?