Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc:add config for hot region history and add command for pd ctl #7163

Merged
merged 15 commits into from
Jan 11, 2022
Merged

doc:add config for hot region history and add command for pd ctl #7163

merged 15 commits into from
Jan 11, 2022

Conversation

qidi1
Copy link
Contributor

@qidi1 qidi1 commented Sep 24, 2021 •
edited
Loading

Signed-off-by: qidi1 1083369179@qq.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

add config for hot region history and add command for pd ctl

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.4 (TiDB 5.3 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 24, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • hfxsd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Sep 24, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn September 24, 2021 03:04
@ti-chi-bot
Copy link
Member

Welcome @qidi1!

It looks like this is your first PR to pingcap/docs-cn 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs-cn. 😃

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2021
@TomShawn TomShawn requested a review from en-jin19 September 24, 2021 03:04
@TomShawn TomShawn added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 24, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Sep 24, 2021 •
edited
Loading

@qidi1 Please perform the following tasks for this PR. Thanks!

JmPotato
JmPotato reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indicate the versions affected by these changes also, I think it's master though.

pd-control.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
pd-configuration-file.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added for-future-release This PR only applies to master for now and might cherry-pick to a future release. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Sep 24, 2021
@TomShawn TomShawn requested a review from JmPotato October 9, 2021 08:39
@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Oct 9, 2021
This was referenced Oct 18, 2021
Merged
Merged
@qidi1 qidi1 mentioned this pull request Oct 18, 2021
Merged
15 tasks
@TomShawn TomShawn added v5.3 This PR/issue applies to TiDB v5.3. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Oct 19, 2021
@qidi1 qidi1 mentioned this pull request Oct 24, 2021
Merged
14 tasks
@TomShawn TomShawn added the for-future-release This PR only applies to master for now and might cherry-pick to a future release. label Nov 3, 2021
hfxsd
hfxsd reviewed Jan 6, 2022
View reviewed changes
pd-configuration-file.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jan 6, 2022
View reviewed changes
pd-configuration-file.md Outdated Show resolved Hide resolved
qidi1 and others added 3 commits January 6, 2022 11:33
@qidi1 @hfxsd
Update pd-configuration-file.md
bed2b0e 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qidi1 @hfxsd
Update pd-configuration-file.md
3741ff0 
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qidi1
address comment
ffeeccd 
Signed-off-by: qidi1 <1083369179@qq.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 6, 2022
qidi1 added 5 commits January 6, 2022 13:30
@qidi1
address comment
893580c 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
pdctl: update hot history usage comment
36a5a3b 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
pdctl: update hot history usage return example
9289edd 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
pdctl: formate hot history usage return example
bceddfd 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
pdctl: update hot history slice use case
54454aa 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1
Copy link
Contributor Author

qidi1 commented Jan 6, 2022

增加了一个commit, 把store_id, region_id, peer_id 的 [1,2,3] 输入方法纠正成 1,2,3。

TomShawn
TomShawn reviewed Jan 10, 2022
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jan 10, 2022
View reviewed changes
pd-configuration-file.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Jan 10, 2022
View reviewed changes
pd-configuration-file.md Outdated Show resolved Hide resolved
@qidi1
address comment
e939595 
Signed-off-by: qidi1 <1083369179@qq.com>
@qidi1 qidi1 force-pushed the hot_history_region branch from 26d2c7f to e939595 Compare January 10, 2022 10:22
TomShawn
TomShawn reviewed Jan 11, 2022
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 11, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 852aea1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 11, 2022
@TomShawn
Copy link
Contributor

/verify

@ti-chi-bot ti-chi-bot merged commit f50160a into pingcap:master Jan 11, 2022
@qidi1 qidi1 mentioned this pull request Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@JmPotato JmPotato JmPotato left review comments

@TomShawn TomShawn TomShawn approved these changes

@nolouch nolouch nolouch approved these changes

@en-jin19 en-jin19 Awaiting requested review from en-jin19

Assignees

@hfxsd hfxsd

@qidi1 qidi1

Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@qidi1 @ti-chi-bot @CLAassistant @TomShawn @JmPotato @nolouch @hfxsd @en-jin19