command:add ctl command to get hot history regions(ref #25281) #4103

qidi1 · 2021-09-11T14:54:44Z

…onfg

Signed-off-by: qidi1 1083369179@qq.com

What problem does this PR solve?
origin pr is here #3989
This PR is oversize and splited into three small one:

Proposal: pingcap/tidb#27487
Associated Issue: pingcap/tidb#25281
Associated PR: pingcap/tidb#27224

What is changed and how it works?
provide pd-ctl command to pull hot_history_regions information

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

No code
Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Code changes

Has configuration change
Has HTTP API interfaces change (Don't forget to add the declarative for API)
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

PR to update:pingcap/docs/pingcap/docs-cn:

Release note

none

ti-chi-bot · 2021-09-11T14:54:45Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

qidi1 · 2021-09-11T15:52:29Z

/run-all-tests

tools/pd-ctl/pdctl/command/hot_command.go

ti-chi-bot · 2021-09-12T02:14:33Z

@IcePigZDB: Request changes is only allowed for the reviewers in list.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

tools/pd-ctl/pdctl/command/hot_command.go

tests/pdctl/hot/hot_test.go

qidi1 · 2021-09-27T06:04:55Z

/run-all-tests

qidi1 · 2021-10-25T12:03:34Z

/run-all-tests

qidi1 · 2021-11-29T11:28:57Z

/run-all-tests

qidi1 · 2021-12-01T09:02:05Z

/run-all-tests

Signed-off-by: qidi1 <1083369179@qq.com>

qidi1 · 2021-12-08T06:49:15Z

/run-all-tests

qidi1 · 2021-12-10T06:08:55Z

/run-all-tests

codecov · 2021-12-10T06:18:03Z

Codecov Report

Merging #4103 (ef3ada4) into master (af174e6) will increase coverage by 0.17%.
The diff coverage is 75.19%.

@@            Coverage Diff             @@
##           master    #4103      +/-   ##
==========================================
+ Coverage   74.86%   75.03%   +0.17%     
==========================================
  Files         264      264              
  Lines       27821    27931     +110     
==========================================
+ Hits        20827    20959     +132     
+ Misses       5134     5113      -21     
+ Partials     1860     1859       -1

Flag	Coverage Δ
unittests	`75.03% <75.19%> (+0.17%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
tools/pd-ctl/pdctl/command/global.go	`69.56% <72.97%> (+0.49%)`	⬆️
tools/pd-ctl/pdctl/command/hot_command.go	`71.32% <76.08%> (+8.58%)`	⬆️
pkg/errs/errs.go	`75.00% <0.00%> (-25.00%)`	⬇️
server/id/id.go	`76.19% <0.00%> (-4.77%)`	⬇️
tools/pd-ctl/pdctl/command/operator.go	`65.99% <0.00%> (-1.22%)`	⬇️
server/election/leadership.go	`77.31% <0.00%> (-1.04%)`	⬇️
server/handler.go	`49.06% <0.00%> (-0.42%)`	⬇️
server/server.go	`71.94% <0.00%> (ø)`
server/grpc_service.go	`51.40% <0.00%> (ø)`
server/member/member.go	`64.70% <0.00%> (ø)`
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af174e6...ef3ada4. Read the comment docs.

Signed-off-by: qidi1 <1083369179@qq.com>

nolouch · 2021-12-14T03:06:41Z

PTAL @lhy1024

nolouch

lgtm.

nolouch · 2021-12-21T05:56:21Z

/merge

ti-chi-bot · 2021-12-21T05:56:21Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-12-21T05:56:23Z

This pull request has been accepted and is ready to merge.

Commit hash: f8b9624

ti-chi-bot · 2021-12-21T05:59:54Z

[FORMAT CHECKER NOTIFICATION]

Please provide the associated issue number in the commit messages, for example: close #12345, or ref #12345.

…4103) * command:add hot-history-regions command(ref #pingcap/tidb/issues/25281) Signed-off-by: qidi1 <1083369179@qq.com> Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 11, 2021

ti-chi-bot requested review from lhy1024 and nolouch September 11, 2021 14:54

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2021

qidi1 mentioned this pull request Sep 11, 2021

api: add interface for hot_region info reqeust #4021

Merged

10 tasks

qidi1 changed the title ~~History hot regions command~~ command:add ctl command to get hot history regions Sep 11, 2021

qidi1 force-pushed the history_hot_regions_command branch from 6d3dd5d to 341c1cb Compare September 11, 2021 15:00

IcePigZDB suggested changes Sep 12, 2021

View reviewed changes

tools/pd-ctl/pdctl/command/hot_command.go Show resolved Hide resolved

tools/pd-ctl/pdctl/command/hot_command.go Show resolved Hide resolved

IcePigZDB reviewed Sep 12, 2021

View reviewed changes

tools/pd-ctl/pdctl/command/hot_command.go Outdated Show resolved Hide resolved

IcePigZDB reviewed Sep 13, 2021

View reviewed changes

tests/pdctl/hot/hot_test.go Outdated Show resolved Hide resolved

qidi1 mentioned this pull request Sep 14, 2021

core:solve bug in hot_region_storage #4121

Merged

14 tasks

qidi1 force-pushed the history_hot_regions_command branch from e7c9945 to 7b70294 Compare October 24, 2021 03:08

ti-chi-bot added the do-not-merge/invalid-commit-message label Oct 24, 2021

qidi1 force-pushed the history_hot_regions_command branch from 0b6ed1b to 12a1927 Compare October 24, 2021 04:45

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2021

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2021

qidi1 force-pushed the history_hot_regions_command branch from 03254e6 to e4d712e Compare November 29, 2021 11:52

ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 29, 2021

qidi1 force-pushed the history_hot_regions_command branch from 3edd9f4 to 6ed54d1 Compare November 29, 2021 12:01

ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 29, 2021

qidi1 changed the title ~~command:add ctl command to get hot history regions~~ command:add ctl command to get hot history regions(ref #25281) Nov 29, 2021

command:bug fix

6103a6e

Signed-off-by: qidi1 <1083369179@qq.com>

qidi1 force-pushed the history_hot_regions_command branch from f46821c to 1240dbc Compare December 10, 2021 03:29

qidi1 force-pushed the history_hot_regions_command branch 3 times, most recently from c1accf9 to d9c2277 Compare December 12, 2021 04:26

command:fix bug of no error info output

62725ba

Signed-off-by: qidi1 <1083369179@qq.com>

qidi1 force-pushed the history_hot_regions_command branch from 6b2edbb to 62725ba Compare December 12, 2021 05:07

Merge branch 'master' into history_hot_regions_command

f8b9624

IcePigZDB mentioned this pull request Dec 21, 2021

docs: add proposal for TiDB_HOT_REGIONS_HISTORY pingcap/tidb#27487

Open

nolouch approved these changes Dec 21, 2021

View reviewed changes

nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Dec 21, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 21, 2021

Merge branch 'master' into history_hot_regions_command

ef3ada4

nolouch merged commit 447fbd4 into tikv:master Dec 21, 2021

qidi1 mentioned this pull request Jan 15, 2022

Store the histroy hot regions #4066

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

command:add ctl command to get hot history regions(ref #25281) #4103

command:add ctl command to get hot history regions(ref #25281) #4103

qidi1 commented Sep 11, 2021 •

edited by nolouch

Loading

ti-chi-bot commented Sep 11, 2021 •

edited

Loading

qidi1 commented Sep 11, 2021

ti-chi-bot commented Sep 12, 2021

qidi1 commented Sep 27, 2021

qidi1 commented Oct 25, 2021

qidi1 commented Nov 29, 2021

qidi1 commented Dec 1, 2021

qidi1 commented Dec 8, 2021

qidi1 commented Dec 10, 2021

codecov bot commented Dec 10, 2021 •

edited

Loading

nolouch commented Dec 14, 2021

nolouch left a comment

nolouch commented Dec 21, 2021

ti-chi-bot commented Dec 21, 2021

ti-chi-bot commented Dec 21, 2021

ti-chi-bot commented Dec 21, 2021

command:add ctl command to get hot history regions(ref #25281) #4103

command:add ctl command to get hot history regions(ref #25281) #4103

Conversation

qidi1 commented Sep 11, 2021 • edited by nolouch Loading

Release note

ti-chi-bot commented Sep 11, 2021 • edited Loading

qidi1 commented Sep 11, 2021

ti-chi-bot commented Sep 12, 2021

qidi1 commented Sep 27, 2021

qidi1 commented Oct 25, 2021

qidi1 commented Nov 29, 2021

qidi1 commented Dec 1, 2021

qidi1 commented Dec 8, 2021

qidi1 commented Dec 10, 2021

codecov bot commented Dec 10, 2021 • edited Loading

Codecov Report

nolouch commented Dec 14, 2021

nolouch left a comment

Choose a reason for hiding this comment

nolouch commented Dec 21, 2021

ti-chi-bot commented Dec 21, 2021

ti-chi-bot commented Dec 21, 2021

ti-chi-bot commented Dec 21, 2021

qidi1 commented Sep 11, 2021 •

edited by nolouch

Loading

ti-chi-bot commented Sep 11, 2021 •

edited

Loading

codecov bot commented Dec 10, 2021 •

edited

Loading