Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add proposal for TiDB_HOT_REGIONS_HISTORY #27487

Open
wants to merge 40 commits into
base: master
Choose a base branch
from

Conversation

IcePigZDB
Copy link
Contributor

@IcePigZDB IcePigZDB commented Aug 23, 2021

Signed-off-by: IcePigZDB icepigzdb@gmail.com
Co-authored-by: qidi1 1083369179@qq.com

What problem does this PR solve?

Issue Number: ref #25281
This PR adds proposal for TiDB_HOT_REGIONS_HISTORY.
There are some dscussion in misplaced PR tikv/rfcs/pull/70, move them to here and close it.

What is changed and how it works?

Implemention PRs:

Release note

None

Signed-off-by: IcePigZDB <icepigzdb@gmail.com>
Co-authored-by: qidi1 <1083369179@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 23, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Aug 23, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@IcePigZDB IcePigZDB changed the title Record history hotspot information in TiDB_HOT_REGIONS_HISTORY docs: add proposal for TiDB_HOT_REGIONS_HISTORY Aug 23, 2021
Signed-off-by: IcePigZDB <icepigzdb@gmail.com>
Co-authored-by: qidi1 <1083369179@qq.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 23, 2021
@CLAassistant
Copy link

CLAassistant commented Aug 25, 2021

CLA assistant check
All committers have signed the CLA.

@nolouch nolouch self-requested a review September 16, 2021 03:32
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 11, 2022
@disksing
Copy link
Contributor

/merge

@disksing disksing closed this Feb 11, 2022
@disksing disksing reopened this Feb 11, 2022
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7980f99

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 11, 2022
docs/design/2021-08-23-history-hot-regions.md Outdated Show resolved Hide resolved
docs/design/2021-08-23-history-hot-regions.md Outdated Show resolved Hide resolved
docs/design/2021-08-23-history-hot-regions.md Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

Merge canceled because a new commit is pushed.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2022
@nolouch
Copy link
Member

nolouch commented Mar 3, 2022

ptal @AndreMouche

Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@IcePigZDB
Copy link
Contributor Author

hi, @AndreMouche, I corrected some markdown lint and English grammar, and all test pass now, ptal.

@hawkingrei
Copy link
Member

@AndreMouche PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants