remove direct placement #8230

xhebox · 2022-01-26T05:42:01Z

Signed-off-by: xhe xw897002528@gmail.com

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

translating pingcap/docs#7400, pingcap/docs#7823

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from: remove direct placement docs#7400
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Signed-off-by: xhe <xw897002528@gmail.com>

ti-chi-bot · 2022-01-26T05:42:03Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: xhe <xw897002528@gmail.com>

xhebox · 2022-03-07T05:42:22Z

Updated with the latest commit of the upstream PR

TomShawn

Questions to be clarified:

Placement options - 放置选项：Should this term be globally modified to "placement rules" or "placement policies"?
Placement rules - 放置规则：What's the difference between "placement rules" and "placement policies"?
Placement policies - 放置策略：The literal translation for "policy" is "策略" instead of "规则". If "placement policies" are translated in the same way as "placement rules", that can be confusing.

Could you please take a look? Thanks! @xhebox @morgo

placement-rules-in-sql.md

sql-statements/sql-statement-alter-placement-policy.md

sql-statements/sql-statement-show-placement-for.md

sql-statements/sql-statement-show-placement.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

xhebox · 2022-03-09T06:18:59Z

@TomShawn

The feature is called placement rules in SQL. But there are only placement policy objects in SQL. These policies themselves are placement rules(which only exists on PD), in SQL context. So policy is almost synonymous as rules now. And most users are using rules/policies at the same time.

So, it is, policies are objects composed of options. You should not modify options. If we really want to unify something, it is policy and rule.

EDIT: my current proposal, if we want to change:

placement options -> placement policy options (放置选项 -> 放置策略选项)
placement rule -> placement policy (放置规则 -> 放置策略)
Add some descriptions on placement rules(PD) and placement policies(TiDB/SQL)

EDIT2:
My intention of changing placement policy -> placement rules (放置策略 -> 放置规则) in the Chinese docs is that most people knowing placement rules(PD) 放置规则, so they just say create placement rules (放置规则) even if they are showing CREATE PLACEMENT POLICY statements.

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Signed-off-by: xhe <xw897002528@gmail.com>

xhebox · 2022-03-10T08:00:28Z

@TomShawn Now it becomes a translation of pingcap/docs#7400 and pingcap/docs#7823

placement-rules-in-sql.md

TomShawn · 2022-03-10T08:41:55Z

placement-rules-in-sql.md


-ALTER DATABASE test FOLLOWERS=2;  -- 再次更改默认的放置选项，此更改不影响已有的表。
+CREATE TABLE t4 (a INT);  -- 创建表 t4，默认的放置策略 p3 生效。


Suggested change

CREATE TABLE t4 (a INT); -- 创建表 t4，默认的放置策略 p3 生效。

CREATE TABLE t4 (a INT); -- 创建表 t4，默认的放置规则 p3 生效。

故意的, p3是策略, 所以这个不改规则.

这里英文中是 rules

那我改一下英文

Creates a table t4 with the default policy p3. 不对啊就是policy

placement-rules-in-sql.md

TomShawn · 2022-03-11T03:56:25Z

placement-rules-in-sql.md

 * TiDB 生态工具，包括 Backup & Restore (BR)、TiCDC、TiDB Lightning 和 TiDB Data Migration (DM)，不支持放置规则。
-* 临时表不支持放置选项，直接放置和放置策略均不支持。
+* 临时表不支持放置规则。


这里英文写的是“placement options”，不知需要把这里的“规则”改回为“选项”，还是改英文的“option”呢？

我觉得不改也行, 这两个都是一种意思. 中文更抽象, 英文更具体.

placement-rules-in-sql.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

sql-statements/sql-statement-alter-placement-policy.md

placement-rules-in-sql.md

TomShawn

rest LGTM

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

information-schema/information-schema-placement-rules.md

placement-rules-in-sql.md

lcwangchao · 2022-03-14T04:21:10Z

placement-rules-in-sql.md

@@ -173,7 +213,7 @@ PARTITION BY RANGE( YEAR(purchased) ) (

 * Dumpling 不支持导出放置策略，见 [issue #29371](https://github.com/pingcap/tidb/issues/29371)。
 * TiDB 生态工具，包括 Backup & Restore (BR)、TiCDC、TiDB Lightning 和 TiDB Data Migration (DM)，不支持放置规则。


目前生态工具的情况是，Lightning 目前不支持放置规则。CDC/Binlog 不会同步 placement 到下游数据库。BR 支持 placement （In review：https://github.com/pingcap/tidb/pull/33007）需要修改下当前文档的描述。

之后需要 @IANTHEREAL @leoppro @sunzhaoyang 看下？

sql-statements/sql-statement-alter-placement-policy.md

placement-rules-in-sql.md

TomShawn · 2022-03-18T07:37:12Z

/remove-status LGT1
/status LGT2

TomShawn · 2022-03-18T07:37:45Z

/merge

ti-chi-bot · 2022-03-18T07:37:47Z

This pull request has been accepted and is ready to merge.

Commit hash: 89e3c74

remove direct placement

eb49657

Signed-off-by: xhe <xw897002528@gmail.com>

xhebox requested review from lcwangchao and TomShawn January 26, 2022 05:42

ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2022

TomShawn added the translation/from-docs This PR is translated from a PR in pingcap/docs. label Jan 27, 2022

ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jan 27, 2022

TomShawn added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Jan 27, 2022

ran-huang added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2022

TomShawn added v6.0 This PR/issue applies to TiDB v6.0. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. labels Mar 4, 2022

sync with the upstream en doc

3b080d1

Signed-off-by: xhe <xw897002528@gmail.com>

TomShawn reviewed Mar 9, 2022

View reviewed changes

*: Update sql-statements/sql-statement-alter-placement-policy.md

4378173

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

xhebox and others added 7 commits March 9, 2022 14:19

Update sql-statements/sql-statement-show-placement.md

dd77576

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update placement-rules-in-sql.md

a92a610

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update sql-statements/sql-statement-show-placement-for.md

e60caae

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update placement-rules-in-sql.md

b996942

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update placement-rules-in-sql.md

285e4c8

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update placement-rules-in-sql.md

3f6b0ab

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

*: address comment

6cda02a

Signed-off-by: xhe <xw897002528@gmail.com>

xhebox mentioned this pull request Mar 10, 2022

*: clarify rules and policies pingcap/docs#7823

Merged

16 tasks

Merge branch 'master' into pr/8230

1fd724a

TomShawn reviewed Mar 11, 2022

View reviewed changes

Update placement-rules-in-sql.md

22ba344

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

xhebox and others added 3 commits March 11, 2022 12:47

Update placement-rules-in-sql.md

009e45f

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update placement-rules-in-sql.md

0a46b03

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

refine

3456873

TomShawn reviewed Mar 11, 2022

View reviewed changes

sql-statements/sql-statement-alter-placement-policy.md Outdated Show resolved Hide resolved

TomShawn reviewed Mar 11, 2022

View reviewed changes

placement-rules-in-sql.md Outdated Show resolved Hide resolved

TomShawn approved these changes Mar 11, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2022

xhebox and others added 2 commits March 11, 2022 13:37

Update placement-rules-in-sql.md

47b3c8a

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Update sql-statements/sql-statement-alter-placement-policy.md

89e3c74

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

lcwangchao reviewed Mar 14, 2022

View reviewed changes

placement-rules-in-sql.md Show resolved Hide resolved

lcwangchao approved these changes Mar 16, 2022

View reviewed changes

xhebox mentioned this pull request Mar 18, 2022

*: refine placement documents pingcap/docs#7885

Merged

16 tasks

TomShawn added v6.0 This PR/issue applies to TiDB v6.0. and removed v6.0 This PR/issue applies to TiDB v6.0. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 18, 2022

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2022

ti-chi-bot merged commit c0ce272 into pingcap:master Mar 18, 2022

xhebox deleted the placement_2 branch March 18, 2022 08:05

xhebox mentioned this pull request Mar 18, 2022

*: refine placement #8706

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove direct placement #8230

remove direct placement #8230

xhebox commented Jan 26, 2022 •

edited

Loading

ti-chi-bot commented Jan 26, 2022 •

edited

Loading

xhebox commented Mar 7, 2022

TomShawn left a comment

xhebox commented Mar 9, 2022 •

edited

Loading

xhebox commented Mar 10, 2022

TomShawn Mar 10, 2022

xhebox Mar 11, 2022

TomShawn Mar 11, 2022

xhebox Mar 11, 2022

xhebox Mar 11, 2022

TomShawn Mar 11, 2022

xhebox Mar 11, 2022

TomShawn left a comment

lcwangchao Mar 14, 2022

TomShawn commented Mar 18, 2022

TomShawn commented Mar 18, 2022

ti-chi-bot commented Mar 18, 2022


		ALTER DATABASE test FOLLOWERS=2; -- 再次更改默认的放置选项，此更改不影响已有的表。
		CREATE TABLE t4 (a INT); -- 创建表 t4，默认的放置策略 p3 生效。

		@@ -173,7 +213,7 @@ PARTITION BY RANGE( YEAR(purchased) ) (

		* Dumpling 不支持导出放置策略，见 [issue #29371](https://github.com/pingcap/tidb/issues/29371)。
		* TiDB 生态工具，包括 Backup & Restore (BR)、TiCDC、TiDB Lightning 和 TiDB Data Migration (DM)，不支持放置规则。

remove direct placement #8230

remove direct placement #8230

Conversation

xhebox commented Jan 26, 2022 • edited Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

ti-chi-bot commented Jan 26, 2022 • edited Loading

xhebox commented Mar 7, 2022

TomShawn left a comment

Choose a reason for hiding this comment

xhebox commented Mar 9, 2022 • edited Loading

xhebox commented Mar 10, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomShawn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomShawn commented Mar 18, 2022

TomShawn commented Mar 18, 2022

ti-chi-bot commented Mar 18, 2022

xhebox commented Jan 26, 2022 •

edited

Loading

ti-chi-bot commented Jan 26, 2022 •

edited

Loading

xhebox commented Mar 9, 2022 •

edited

Loading