-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: refine placement #8706
*: refine placement #8706
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
||
# PLACEMENT_RULES | ||
|
||
`PLACEMENT_RULES` 表展示所有已显式配置的 [Placement Rules in SQL](/placement-rules-in-sql.md) 信息,即所有放置策略 (placement policy) 的信息。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在 v6.0 中这张系统表被 PLACEMENT_POLICIES
替代了吗?所以打破了自身兼容性了吧?
/rebase |
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Co-authored-by: 王超 <cclcwangchao@hotmail.com>
Co-authored-by: 王超 <cclcwangchao@hotmail.com>
Co-authored-by: 王超 <cclcwangchao@hotmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: xhe <xw897002528@gmail.com>
system-variables.md
Outdated
@@ -1290,6 +1283,14 @@ explain select * from t where age=5; | |||
- 默认值:`ON` | |||
- 这个变量用于控制是否开启 [ANALYZE 配置持久化](/statistics.md#analyze-配置持久化)特性。 | |||
|
|||
### `tidb_placement_mode` <span class="version-mark">从 v6.0.0 版本开始引入</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
前端支持原因,暂时用不了 了
### `tidb_placement_mode` <span class="version-mark">从 v6.0.0 版本开始引入</span> | |
### `tidb_placement_mode`(从 v6.0.0 版本开始引入) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomShawn 英文要改嘛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
要的
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: 王超 <cclcwangchao@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
/remove-status LGT1 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 56fe1a8
|
@@ -98,8 +130,11 @@ SELECT * FROM information_schema.partitions WHERE tidb_placement_policy_name IS | |||
|
|||
| 选项名 | 描述 | | |||
|----------------------------|------------------------------------------------------------------------------------------------| | |||
| `CONSTRAINTS` | 适用于所有角色 (role) 的约束列表。例如,`CONSTRAINTS="[+disk=ssd]`。 | | |||
| `FOLLOWER_CONSTRAINTS` | 仅适用于 follower 的约束列表。 | | |||
| `CONSTRAINTS` | 适用于所有角色 (role) 的约束列表。例如,`CONSTRAINTS="[+disk=ssd]`。 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 ]
后面少了 "
?
|
||
| 工具名称 | 最低兼容版本 | 说明 | | ||
| --- | --- | --- | | ||
| Backup & Restore (BR) | 6.0 | 支持放置规则的导入与导出,见 [BR 兼容性](/br/backup-and-restore-tool.md#兼容性] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
br 兼容性链接后面缺 )
Signed-off-by: xhe xw897002528@gmail.com
First-time contributors' checklist
What is changed, added or deleted? (Required)
PLACEMENT_RULES
table.VOTERS
as the implementationWhich TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?