Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: refine placement #8706

Merged
merged 26 commits into from
Mar 23, 2022
Merged

*: refine placement #8706

merged 26 commits into from
Mar 23, 2022

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Mar 18, 2022

Signed-off-by: xhe xw897002528@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

  1. Address remove direct placement #8230 (comment), rename PLACEMENT_RULES table.
  2. Address remove direct placement #8230 (comment), restructure syntax tree
  3. Remove VOTERS as the implementation
  4. Refines on the introduction page, changes are marked out

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 18, 2022 08:06
@xhebox xhebox requested review from lcwangchao and removed request for TomShawn March 18, 2022 08:06
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Mar 18, 2022
@xhebox xhebox requested a review from TomShawn March 18, 2022 08:06
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 18, 2022
@xhebox xhebox requested a review from lcwangchao March 18, 2022 10:59
@shichun-0415 shichun-0415 added translation/from-docs This PR is translated from a PR in pingcap/docs. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. and removed missing-translation-status This PR does not have translation status info. labels Mar 18, 2022
@TomShawn TomShawn added the v6.0 This PR/issue applies to TiDB v6.0. label Mar 21, 2022

# PLACEMENT_RULES

`PLACEMENT_RULES` 表展示所有已显式配置的 [Placement Rules in SQL](/placement-rules-in-sql.md) 信息,即所有放置策略 (placement policy) 的信息。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在 v6.0 中这张系统表被 PLACEMENT_POLICIES 替代了吗?所以打破了自身兼容性了吧?

@TomShawn
Copy link
Contributor

/rebase

xhebox and others added 7 commits March 21, 2022 03:23
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Co-authored-by: 王超 <cclcwangchao@hotmail.com>
Co-authored-by: 王超 <cclcwangchao@hotmail.com>
Co-authored-by: 王超 <cclcwangchao@hotmail.com>
xhebox and others added 2 commits March 22, 2022 11:14
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@@ -1290,6 +1283,14 @@ explain select * from t where age=5;
- 默认值:`ON`
- 这个变量用于控制是否开启 [ANALYZE 配置持久化](/statistics.md#analyze-配置持久化)特性。

### `tidb_placement_mode` <span class="version-mark">从 v6.0.0 版本开始引入</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前端支持原因,暂时用不了

Suggested change
### `tidb_placement_mode` <span class="version-mark">从 v6.0.0 版本开始引入</span>
### `tidb_placement_mode`从 v6.0.0 版本开始引入

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomShawn 英文要改嘛

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要的

xhebox and others added 2 commits March 22, 2022 16:12
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
placement-rules-in-sql.md Outdated Show resolved Hide resolved
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
br/backup-and-restore-tool.md Outdated Show resolved Hide resolved
placement-rules-in-sql.md Outdated Show resolved Hide resolved
xhebox and others added 2 commits March 22, 2022 17:20
Co-authored-by: 王超 <cclcwangchao@hotmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

placement-rules-in-sql.md Outdated Show resolved Hide resolved
xhebox and others added 3 commits March 23, 2022 12:47
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2022
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 56fe1a8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2022
@ti-chi-bot ti-chi-bot merged commit bc761fb into pingcap:master Mar 23, 2022
@@ -98,8 +130,11 @@ SELECT * FROM information_schema.partitions WHERE tidb_placement_policy_name IS

| 选项名 | 描述 |
|----------------------------|------------------------------------------------------------------------------------------------|
| `CONSTRAINTS` | 适用于所有角色 (role) 的约束列表。例如,`CONSTRAINTS="[+disk=ssd]`。 |
| `FOLLOWER_CONSTRAINTS` | 仅适用于 follower 的约束列表。 |
| `CONSTRAINTS` | 适用于所有角色 (role) 的约束列表。例如,`CONSTRAINTS="[+disk=ssd]`。 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 ] 后面少了 "?


| 工具名称 | 最低兼容版本 | 说明 |
| --- | --- | --- |
| Backup & Restore (BR) | 6.0 | 支持放置规则的导入与导出,见 [BR 兼容性](/br/backup-and-restore-tool.md#兼容性] |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

br 兼容性链接后面缺 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.0 This PR/issue applies to TiDB v6.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants