zh: add handle-error-sql-statements.md #227

GMHDBJD · 2020-08-14T03:23:19Z

What is changed, added or deleted? (Required)

add handle-error-sql-statements.md

sql-skip/sql-replace 重构为 handle-error, 删除了原有的文档，新增的 handle-failed-sql-statements 借鉴了原来文档的结构和部分使用场景。其余地方几乎都不一样。

Which DM version(s) do your changes apply to? (Required)

master (the latest development version, including v2.0 changes for now)
v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

DM#850

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Have version specific changes
Might cause conflicts

csuzhangxc

rest LGTM

zh/handle-error-sql-statements.md

csuzhangxc · 2020-08-14T06:43:53Z

zh/handle-error-sql-statements.md

+
+### 命令介绍
+
+使用 dmctl 手动处理出错的 SQL 语句时，主要使用的命令包括 `query-status`、`handle-error`。


把 handle-error 淡化掉吧？

啥意思？😂

我看错了，无视我，我以为是 query-error. 😢

csuzhangxc · 2020-08-14T06:45:21Z

zh/handle-error-sql-statements.md

+| Table | Create Table                                                                                              |
+-------+-----------------------------------------------------------------------------------------------------------+
+| tb    | CREATE TABLE `shard_table` (
+  `id` int(11) DEFAULT NULL


要不要加一下 PK。

csuzhangxc · 2020-08-14T06:51:21Z

zh/handle-error-sql-statements.md

+
+- 比如：`DROP PRIMARY KEY`，这种情况下，只能在下游重建一个（DDL 执行完后的）新表结构对应的表，并将原表的全部数据重新导入该新表。
+
+### 支持场景


感觉这个文档的三/四级标题，可以提升为二/三级标题？

zh/handle-error-sql-statements.md

csuzhangxc · 2020-08-14T06:53:57Z

zh/handle-error-sql-statements.md

+                                "ErrClass": "schema-tracker",
+                                "ErrScope": "internal",
+                                "ErrLevel": "high",
+                                "Message": "startLocation: [position: (DESKTOP-T561TSO-bin.000001, 1420), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4], endLocation: [position: (DESKTOP-T561TSO-bin.000001, 1634), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4]: cannot track DDL: ALTER TABLE `shard_db_1`.`shard_table_1` CHARACTER SET UTF8 COLLATE UTF8_UNICODE_CI",


这文档里的 query-status 结果的 block，我们要不要省略掉一些信息（比如用 ...），只保留关键的信息，方便用户抓住重点。

或者可以用 <details> <summary> HTML 标签进行折叠（不过尽量能省则省吧，这么长就算折叠起来也很难看）：

执行结果

{ "result": true, "msg": "", "sources": [ { "result": true, "msg": "", "sourceStatus": { "source": "mysql-replica-01", "worker": "worker1", "result": null, "relayStatus": null }, "subTaskStatus": [ { "name": "test", "stage": "Paused", "unit": "Sync", "result": { "isCanceled": false, "errors": [ { "ErrCode": 44006, "ErrClass": "schema-tracker", "ErrScope": "internal", "ErrLevel": "high", "Message": "startLocation: [position: (DESKTOP-T561TSO-bin.000001, 1420), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4], endLocation: [position: (DESKTOP-T561TSO-bin.000001, 1634), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4]: cannot track DDL: ALTER TABLE `shard_db_1`.`shard_table_1` CHARACTER SET UTF8 COLLATE UTF8_UNICODE_CI", "RawCause": "[ddl:8200]Unsupported modify charset from latin1 to utf8", "Workaround": "" } ], "detail": null }, "unresolvedDDLLockID": "", "sync": { "totalEvents": "2", "totalTps": "0", "recentTps": "0", "masterBinlog": "(DESKTOP-T561TSO-bin.000001, 1848)", "masterBinlogGtid": "143bdef3-dd4a-11ea-8b00-00155de45f57:1-8", "syncerBinlog": "(DESKTOP-T561TSO-bin.000001, 1420)", "syncerBinlogGtid": "143bdef3-dd4a-11ea-8b00-00155de45f57:1-4", "blockingDDLs": [ ], "unresolvedGroups": [ { "target": "`shard_db`.`shard_table`", "DDLs": [ "ALTER TABLE `shard_db`.`shard_table` CHARACTER SET UTF8 COLLATE UTF8_UNICODE_CI" ], "firstLocation": "position: (DESKTOP-T561TSO-bin.000001, 1420), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4", "synced": [ "`shard_db_1`.`shard_table_1`" ], "unsynced": [ "`shard_db_1`.`shard_table_2`" ] } ], "synced": false, "binlogType": "remote" } } ] }, { "result": true, "msg": "", "sourceStatus": { "source": "mysql-replica-02", "worker": "worker2", "result": null, "relayStatus": null }, "subTaskStatus": [ { "name": "test", "stage": "Paused", "unit": "Sync", "result": { "isCanceled": false, "errors": [ { "ErrCode": 44006, "ErrClass": "schema-tracker", "ErrScope": "internal", "ErrLevel": "high", "Message": "startLocation: [position: (DESKTOP-T561TSO-bin.000001, 1420), gtid-set: 1d66ce48-dd4a-11ea-8ef7-00155de45f57:1-6], endLocation: [position: (DESKTOP-T561TSO-bin.000001, 1634), gtid-set: 1d66ce48-dd4a-11ea-8ef7-00155de45f57:1-7]: cannot track DDL: ALTER TABLE `shard_db_2`.`shard_table_1` CHARACTER SET UTF8 COLLATE UTF8_UNICODE_CI", "RawCause": "[ddl:8200]Unsupported modify charset from latin1 to utf8", "Workaround": "" } ], "detail": null }, "unresolvedDDLLockID": "", "sync": { "totalEvents": "2", "totalTps": "0", "recentTps": "0", "masterBinlog": "(DESKTOP-T561TSO-bin.000001, 1848)", "masterBinlogGtid": "1d66ce48-dd4a-11ea-8ef7-00155de45f57:1-8", "syncerBinlog": "(DESKTOP-T561TSO-bin.000001, 1420)", "syncerBinlogGtid": "1d66ce48-dd4a-11ea-8ef7-00155de45f57:1-6", "blockingDDLs": [ ], "unresolvedGroups": [ { "target": "`shard_db`.`shard_table`", "DDLs": [ "ALTER TABLE `shard_db`.`shard_table` CHARACTER SET UTF8 COLLATE UTF8_UNICODE_CI" ], "firstLocation": "position: (DESKTOP-T561TSO-bin.000001, 1420), gtid-set: 1d66ce48-dd4a-11ea-8ef7-00155de45f57:1-6", "synced": [ "`shard_db_2`.`shard_table_1`" ], "unsynced": [ "`shard_db_2`.`shard_table_2`" ] } ], "synced": false, "binlogType": "remote" } } ] } ] }

csuzhangxc · 2020-08-14T06:54:26Z

zh/handle-error-sql-statements.md

+| Table | Create Table                                                                                              |
+-------+-----------------------------------------------------------------------------------------------------------+
+| tb    | CREATE TABLE `shard_table` (
+  `id` int(11) DEFAULT NULL


csuzhangxc · 2020-08-14T06:57:59Z

zh/handle-error-sql-statements.md

+
+##### 应用场景
+
+假设现在存在如下四个上游表需要合并同步到下游的同一个表 ``` `shard_db`.`shard_table` ```，任务模式为悲观协调模式：


我们要不要加一个简单的，没有合库合表的示例？那个可能反而是大多数场景

yikeke · 2020-08-14T07:26:17Z

hi @GMHDBJD ，可以在 pr 描述里概括下你做的改动吗？两个修改的文件太大且没有 diff，不确定你修改的地方，不方便 review

zh/handle-error-sql-statements.md

yikeke · 2020-08-14T07:34:04Z

zh/handle-error-sql-statements.md

@@ -0,0 +1,1020 @@
+---


建议把文件名换成 handle-failed-sql-statements.md，这样更有助于从字面上理解

zh/handle-error-sql-statements.md

yikeke · 2020-08-14T07:37:31Z

zh/handle-error-sql-statements.md

+                                "ErrClass": "schema-tracker",
+                                "ErrScope": "internal",
+                                "ErrLevel": "high",
+                                "Message": "startLocation: [position: (DESKTOP-T561TSO-bin.000001, 1420), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4], endLocation: [position: (DESKTOP-T561TSO-bin.000001, 1634), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4]: cannot track DDL: ALTER TABLE `shard_db_1`.`shard_table_1` CHARACTER SET UTF8 COLLATE UTF8_UNICODE_CI",


yikeke · 2020-08-14T07:40:44Z

zh/handle-error-sql-statements.md

+                                "ErrClass": "schema-tracker",
+                                "ErrScope": "internal",
+                                "ErrLevel": "high",
+                                "Message": "startLocation: [position: (DESKTOP-T561TSO-bin.000001, 1420), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4], endLocation: [position: (DESKTOP-T561TSO-bin.000001, 1634), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4]: cannot track DDL: ALTER TABLE `shard_db_1`.`shard_table_1` CHARACTER SET UTF8 COLLATE UTF8_UNICODE_CI",


或者可以用 <details> <summary> HTML 标签进行折叠（不过尽量能省则省吧，这么长就算折叠起来也很难看）：

执行结果

{ "result": true, "msg": "", "sources": [ { "result": true, "msg": "", "sourceStatus": { "source": "mysql-replica-01", "worker": "worker1", "result": null, "relayStatus": null }, "subTaskStatus": [ { "name": "test", "stage": "Paused", "unit": "Sync", "result": { "isCanceled": false, "errors": [ { "ErrCode": 44006, "ErrClass": "schema-tracker", "ErrScope": "internal", "ErrLevel": "high", "Message": "startLocation: [position: (DESKTOP-T561TSO-bin.000001, 1420), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4], endLocation: [position: (DESKTOP-T561TSO-bin.000001, 1634), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4]: cannot track DDL: ALTER TABLE `shard_db_1`.`shard_table_1` CHARACTER SET UTF8 COLLATE UTF8_UNICODE_CI", "RawCause": "[ddl:8200]Unsupported modify charset from latin1 to utf8", "Workaround": "" } ], "detail": null }, "unresolvedDDLLockID": "", "sync": { "totalEvents": "2", "totalTps": "0", "recentTps": "0", "masterBinlog": "(DESKTOP-T561TSO-bin.000001, 1848)", "masterBinlogGtid": "143bdef3-dd4a-11ea-8b00-00155de45f57:1-8", "syncerBinlog": "(DESKTOP-T561TSO-bin.000001, 1420)", "syncerBinlogGtid": "143bdef3-dd4a-11ea-8b00-00155de45f57:1-4", "blockingDDLs": [ ], "unresolvedGroups": [ { "target": "`shard_db`.`shard_table`", "DDLs": [ "ALTER TABLE `shard_db`.`shard_table` CHARACTER SET UTF8 COLLATE UTF8_UNICODE_CI" ], "firstLocation": "position: (DESKTOP-T561TSO-bin.000001, 1420), gtid-set: 143bdef3-dd4a-11ea-8b00-00155de45f57:1-4", "synced": [ "`shard_db_1`.`shard_table_1`" ], "unsynced": [ "`shard_db_1`.`shard_table_2`" ] } ], "synced": false, "binlogType": "remote" } } ] }, { "result": true, "msg": "", "sourceStatus": { "source": "mysql-replica-02", "worker": "worker2", "result": null, "relayStatus": null }, "subTaskStatus": [ { "name": "test", "stage": "Paused", "unit": "Sync", "result": { "isCanceled": false, "errors": [ { "ErrCode": 44006, "ErrClass": "schema-tracker", "ErrScope": "internal", "ErrLevel": "high", "Message": "startLocation: [position: (DESKTOP-T561TSO-bin.000001, 1420), gtid-set: 1d66ce48-dd4a-11ea-8ef7-00155de45f57:1-6], endLocation: [position: (DESKTOP-T561TSO-bin.000001, 1634), gtid-set: 1d66ce48-dd4a-11ea-8ef7-00155de45f57:1-7]: cannot track DDL: ALTER TABLE `shard_db_2`.`shard_table_1` CHARACTER SET UTF8 COLLATE UTF8_UNICODE_CI", "RawCause": "[ddl:8200]Unsupported modify charset from latin1 to utf8", "Workaround": "" } ], "detail": null }, "unresolvedDDLLockID": "", "sync": { "totalEvents": "2", "totalTps": "0", "recentTps": "0", "masterBinlog": "(DESKTOP-T561TSO-bin.000001, 1848)", "masterBinlogGtid": "1d66ce48-dd4a-11ea-8ef7-00155de45f57:1-8", "syncerBinlog": "(DESKTOP-T561TSO-bin.000001, 1420)", "syncerBinlogGtid": "1d66ce48-dd4a-11ea-8ef7-00155de45f57:1-6", "blockingDDLs": [ ], "unresolvedGroups": [ { "target": "`shard_db`.`shard_table`", "DDLs": [ "ALTER TABLE `shard_db`.`shard_table` CHARACTER SET UTF8 COLLATE UTF8_UNICODE_CI" ], "firstLocation": "position: (DESKTOP-T561TSO-bin.000001, 1420), gtid-set: 1d66ce48-dd4a-11ea-8ef7-00155de45f57:1-6", "synced": [ "`shard_db_2`.`shard_table_1`" ], "unsynced": [ "`shard_db_2`.`shard_table_2`" ] } ], "synced": false, "binlogType": "remote" } } ] } ] }

yikeke · 2020-08-14T07:45:02Z

zh/handle-error-sql-statements.md

+}
+```
+
+可以看到 MySQL 实例1的 `shard_db_1`.`shard_table_1`表和 MySQL 实例2的 `shard_db_2`.`shard_table_1` 表报错。假设业务上可以接受下游 TiDB 不执行此 DDL 语句（即继续保持原有的表结构），则可以通过使用 `handle-error <task-name> skip` 命令跳过该 DDL 语句以恢复同步任务。操作步骤如下：


Suggested change

可以看到 MySQL 实例1的 `shard_db_1`.`shard_table_1`表和 MySQL 实例2的 `shard_db_2`.`shard_table_1` 表报错。假设业务上可以接受下游 TiDB 不执行此 DDL 语句（即继续保持原有的表结构），则可以通过使用 `handle-error <task-name> skip` 命令跳过该 DDL 语句以恢复同步任务。操作步骤如下：

可以看到 MySQL 实例 1 的 `shard_db_1`.`shard_table_1` 表和 MySQL 实例 2 的 `shard_db_2`.`shard_table_1` 表报错。假设业务上可以接受下游 TiDB 不执行此 DDL 语句（即继续保持原有的表结构），则可以通过使用 `handle-error <task-name> skip` 命令跳过该 DDL 语句以恢复同步任务。操作步骤如下：

文档风格统一的问题：中英文之间、中文和数字之间是需要空格的，麻烦批量改下

Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

GMHDBJD · 2020-08-14T10:23:53Z

PTAL again. 我直接把错误信息提炼出来了，会不会太简洁了。。。

csuzhangxc · 2020-08-14T10:31:34Z

zh/handle-failed-sql-statements.md

+
+ `replace`：替代错误的 DDL 语句
+
+ `revert`：重置该错误先前的 skip/replace 操作


要说明一下仅在先前的操作没有最终生效前执行吗？怕用户以为能够 rollback 到更早的地方去（虽然显然是不会的

zh/handle-failed-sql-statements.md

yikeke · 2020-08-14T11:39:36Z

zh/handle-failed-sql-statements.md

+    » query-status test
+    ```
+
+    ```


这种太长的结果考虑折叠下不？ @GMHDBJD @csuzhangxc 可以使整篇文章看起来更简洁些😂

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

ti-srebot · 2020-08-16T11:40:44Z

@csuzhangxc, @yikeke, @ireneontheway, PTAL.

csuzhangxc

LGTM

yikeke

LGTM

yikeke · 2020-08-18T05:29:54Z

/merge

ti-srebot · 2020-08-18T05:32:10Z

/run-all-tests

* align #227 * Update en/handle-failed-sql-statements.md * Apply suggestions from code review Co-authored-by: GMHDBJD <35025882+GMHDBJD@users.noreply.github.com> * Update en/handle-failed-sql-statements.md * Apply suggestions from code review Co-authored-by: Lilian Lee <lilin@pingcap.com> * Update en/handle-failed-sql-statements.md Co-authored-by: GMHDBJD <35025882+GMHDBJD@users.noreply.github.com> Co-authored-by: Lilian Lee <lilin@pingcap.com>

GMHDBJD added 2 commits August 14, 2020 11:19

zh: add handle-error-sql-statements.md

ba945ed

fix lint

15cb6a6

ireneontheway requested review from ireneontheway and csuzhangxc August 14, 2020 05:21

ireneontheway self-assigned this Aug 14, 2020

ireneontheway added status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. v2.0 This PR/issue applies to TiDB DM v2.0. labels Aug 14, 2020

yikeke self-requested a review August 14, 2020 06:06

csuzhangxc reviewed Aug 14, 2020

View reviewed changes

yikeke reviewed Aug 14, 2020

View reviewed changes

GMHDBJD and others added 9 commits August 14, 2020 15:45

Update zh/handle-error-sql-statements.md

4bcc641

Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>

Update zh/handle-error-sql-statements.md

7fb55e1

Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>

Update zh/handle-error-sql-statements.md

dfa54c5

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

Update zh/handle-error-sql-statements.md

4297430

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

address comment

fc65cf8

fix lint

d7f5a36

fix dead link

9b6a54e

fix dead link

a27c92d

minor fix

afbdc7a

csuzhangxc reviewed Aug 14, 2020

View reviewed changes

csuzhangxc mentioned this pull request Aug 14, 2020

feat: add handle-error command pingcap/dm#850

Merged

yikeke reviewed Aug 14, 2020

View reviewed changes

zh/handle-failed-sql-statements.md Outdated Show resolved Hide resolved

zh/handle-failed-sql-statements.md Outdated Show resolved Hide resolved

zh/handle-failed-sql-statements.md Outdated Show resolved Hide resolved

zh/handle-failed-sql-statements.md Outdated Show resolved Hide resolved

yikeke reviewed Aug 14, 2020

View reviewed changes

GMHDBJD and others added 3 commits August 14, 2020 19:47

Update zh/handle-failed-sql-statements.md

eba969d

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

Update zh/handle-failed-sql-statements.md

dc0a5fa

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

Update zh/handle-failed-sql-statements.md

9846271

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

GMHDBJD and others added 5 commits August 14, 2020 19:48

Update zh/handle-failed-sql-statements.md

f3b94f1

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>

address comment

5654467

fix fmt

40d9e8f

fix lint

6fc5b34

fix lint

c739d08

csuzhangxc approved these changes Aug 17, 2020

View reviewed changes

ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2020

Merge branch 'master' into addHandleError

3b4f250

ireneontheway added the size/large Changes of a large size. label Aug 17, 2020

Update handle-failed-sql-statements.md

d3e11e1

yikeke approved these changes Aug 18, 2020

View reviewed changes

ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 18, 2020

ti-srebot approved these changes Aug 18, 2020

View reviewed changes

ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 18, 2020

ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2020

Merge branch 'master' into addHandleError

38454d7

ti-srebot merged commit 08f1ead into pingcap:master Aug 18, 2020

ireneontheway assigned yikeke and unassigned ireneontheway Aug 18, 2020

yikeke pushed a commit to yikeke/docs-dm that referenced this pull request Aug 21, 2020

align pingcap#227

085d555

yikeke mentioned this pull request Aug 21, 2020

Add handle-failed-sql-statements.md #273

Merged

6 tasks

yikeke added translation/done This PR has been translated. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zh: add handle-error-sql-statements.md #227

zh: add handle-error-sql-statements.md #227

GMHDBJD commented Aug 14, 2020 •

edited

Loading

csuzhangxc left a comment

csuzhangxc Aug 14, 2020

GMHDBJD Aug 14, 2020

csuzhangxc Aug 14, 2020

csuzhangxc Aug 14, 2020

csuzhangxc Aug 14, 2020

csuzhangxc Aug 14, 2020

yikeke Aug 14, 2020

yikeke Aug 14, 2020

csuzhangxc Aug 14, 2020

csuzhangxc Aug 14, 2020

yikeke commented Aug 14, 2020 •

edited

Loading

yikeke Aug 14, 2020

yikeke Aug 14, 2020

yikeke Aug 14, 2020

yikeke Aug 14, 2020

GMHDBJD commented Aug 14, 2020

csuzhangxc Aug 14, 2020

yikeke Aug 14, 2020

ti-srebot commented Aug 16, 2020

csuzhangxc left a comment

yikeke left a comment

yikeke commented Aug 18, 2020

ti-srebot commented Aug 18, 2020


		### 命令介绍

		使用 dmctl 手动处理出错的 SQL 语句时，主要使用的命令包括 `query-status`、`handle-error`。


		- 比如：`DROP PRIMARY KEY`，这种情况下，只能在下游重建一个（DDL 执行完后的）新表结构对应的表，并将原表的全部数据重新导入该新表。

		### 支持场景


		##### 应用场景

		假设现在存在如下四个上游表需要合并同步到下游的同一个表 ``` `shard_db`.`shard_table` ```，任务模式为悲观协调模式：

	可以看到 MySQL 实例1的 `shard_db_1`.`shard_table_1`表和 MySQL 实例2的 `shard_db_2`.`shard_table_1` 表报错。假设业务上可以接受下游 TiDB 不执行此 DDL 语句（即继续保持原有的表结构），则可以通过使用 `handle-error <task-name> skip` 命令跳过该 DDL 语句以恢复同步任务。操作步骤如下：
	可以看到 MySQL 实例 1 的 `shard_db_1`.`shard_table_1` 表和 MySQL 实例 2 的 `shard_db_2`.`shard_table_1` 表报错。假设业务上可以接受下游 TiDB 不执行此 DDL 语句（即继续保持原有的表结构），则可以通过使用 `handle-error <task-name> skip` 命令跳过该 DDL 语句以恢复同步任务。操作步骤如下：


		+ `replace`：替代错误的 DDL 语句

		+ `revert`：重置该错误先前的 skip/replace 操作

zh: add handle-error-sql-statements.md #227

zh: add handle-error-sql-statements.md #227

Conversation

GMHDBJD commented Aug 14, 2020 • edited Loading

What is changed, added or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

csuzhangxc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yikeke commented Aug 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GMHDBJD commented Aug 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ti-srebot commented Aug 16, 2020

csuzhangxc left a comment

Choose a reason for hiding this comment

yikeke left a comment

Choose a reason for hiding this comment

yikeke commented Aug 18, 2020

ti-srebot commented Aug 18, 2020

GMHDBJD commented Aug 14, 2020 •

edited

Loading

yikeke commented Aug 14, 2020 •

edited

Loading