Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

Add handle-failed-sql-statements.md #273

Merged
merged 9 commits into from
Aug 21, 2020
Merged

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Aug 21, 2020

What is changed, added or deleted? (Required)

  1. Replace skip-or-replace-abnormal-sql-statements.md with handle-failed-sql-statements.md. The structure is similar to the old file. And some of the content are the same.
  2. fix a typo: handle

Which DM version(s) do your changes apply to? (Required)

  • master (the latest development version, including v2.0 changes for now)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@yikeke yikeke added status/PTAL This PR is ready for reviewing. translation/done This PR has been translated. v2.0 This PR/issue applies to TiDB DM v2.0. translation/from-zh This PR is translated from a PR in docs-dm/zh. and removed translation/done This PR has been translated. labels Aug 21, 2020
Co-authored-by: GMHDBJD <35025882+GMHDBJD@users.noreply.github.com>
en/handle-failed-sql-statements.md Outdated Show resolved Hide resolved
en/handle-failed-sql-statements.md Show resolved Hide resolved
en/handle-failed-sql-statements.md Outdated Show resolved Hide resolved
ALTER TABLE `shard_db_*`.`shard_table_*` ADD COLUMN new_col INT UNIQUE;
```

Because this DDL statement is not supported by TiDB, the replication task gets interrupted. Execute the `query-status` command, and you can see the following errors reported by the `shard_db_1`.`shard_table_1` table in MySQL instance 1 and the `shard_db_2`.`shard_table_1` table in MySQL instance 2:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Because this DDL statement is not supported by TiDB, the replication task gets interrupted. Execute the `query-status` command, and you can see the following errors reported by the `shard_db_1`.`shard_table_1` table in MySQL instance 1 and the `shard_db_2`.`shard_table_1` table in MySQL instance 2:
Because this DDL statement is not supported by TiDB, the replication task gets interrupted. Execute the `query-status` command, and you can see the following errors reported by the `shard_db_1`.`shard_table_2` table in MySQL instance 1 and the `shard_db_2`.`shard_table_2` table in MySQL instance 2:

Copy link
Contributor Author

@yikeke yikeke Aug 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Chinese is: 使用 query-status 命令可以看到 MySQL 实例 1 的 shard_db_1.shard_table_1 表和 MySQL 实例 2 的 shard_db_2.shard_table_1 表报错

See https://github.com/pingcap/docs-dm/pull/227/files#diff-d3fb6a8192d1638d8692792342e48762R570

So the original version should be right? @csuzhangxc

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be right.

yikeke and others added 2 commits August 21, 2020 15:32
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Aug 21, 2020

LGTM

@ti-srebot
Copy link
Contributor

@GMHDBJD,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 21, 2020
@yikeke
Copy link
Contributor Author

yikeke commented Aug 21, 2020

PTAL again @csuzhangxc

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 21, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 21, 2020
@yikeke
Copy link
Contributor Author

yikeke commented Aug 21, 2020

/merge

@yikeke yikeke merged commit f5619fe into pingcap:master Aug 21, 2020
@yikeke yikeke deleted the handle-failed-sql branch August 21, 2020 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-zh This PR is translated from a PR in docs-dm/zh. v2.0 This PR/issue applies to TiDB DM v2.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants